src/effects/SkMatrixConvolutionImageFilter.cpp - Issue 1535353002: change all factories to return their base-class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 1535353002: change all factories to return their base-class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMatrixConvolutionImageFilter.cpp

diff --git a/src/effects/SkMatrixConvolutionImageFilter.cpp b/src/effects/SkMatrixConvolutionImageFilter.cpp

index a1f23f7a290b8b0837fd3ca1efc7f9e02a48cd1c..a80ba45fdbf944eb28b38887e8638cba28aa9ee5 100644

--- a/src/effects/SkMatrixConvolutionImageFilter.cpp

+++ b/src/effects/SkMatrixConvolutionImageFilter.cpp

@@ -47,7 +47,7 @@ SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(

SkASSERT(kernelOffset.fY >= 0 && kernelOffset.fY < kernelSize.fHeight);

}

-SkMatrixConvolutionImageFilter* SkMatrixConvolutionImageFilter::Create(

+SkImageFilter* SkMatrixConvolutionImageFilter::Create(

const SkISize& kernelSize,

const SkScalar* kernel,

SkScalar gain,

« no previous file with comments | « src/effects/SkEmbossMaskFilter.cpp ('k') | tests/AsADashTest.cpp » ('j') | no next file with comments »