tests/SerializationTest.cpp - Issue 1535353002: change all factories to return their base-class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SerializationTest.cpp

Issue 1535353002: change all factories to return their base-class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SerializationTest.cpp

diff --git a/tests/SerializationTest.cpp b/tests/SerializationTest.cpp

index 38e84bd4b431061cef586a9f98677adae038fff6..ba95ddf8da25f56a33bf3d5175605aa413d0fe4a 100644

--- a/tests/SerializationTest.cpp

+++ b/tests/SerializationTest.cpp

@@ -246,7 +246,7 @@ static void TestBitmapSerialization(const SkBitmap& validBitmap,

SkAutoTUnref<SkImage> invalidImage(SkImage::NewFromBitmap(invalidBitmap));

SkAutoTUnref<SkImageFilter> invalidBitmapSource(SkImageSource::Create(invalidImage));

SkAutoTUnref<SkXfermode> mode(SkXfermode::Create(SkXfermode::kSrcOver_Mode));

- SkAutoTUnref<SkXfermodeImageFilter> xfermodeImageFilter(

+ SkAutoTUnref<SkImageFilter> xfermodeImageFilter(

SkXfermodeImageFilter::Create(mode, invalidBitmapSource, validBitmapSource));

SkAutoTUnref<SkImageFilter> deserializedFilter(

« no previous file with comments | « tests/PictureTest.cpp ('k') | no next file » | no next file with comments »