Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1531403003: Delete the ViewManager and WindowManager services. (Closed)

Created:
5 years ago by jeffbrown
Modified:
4 years, 11 months ago
Reviewers:
abarth, viettrungluu, jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-3
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete the ViewManager and WindowManager services. These services have been superceded by Mozart. BUG= Review URL: https://codereview.chromium.org/1530333005 . R=abarth@google.com, abarth, jamesr, viettrungluu Committed: https://chromium.googlesource.com/external/mojo/+/c837be78d25cb96843171f3f3f982bffd0dabed5

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -26749 lines) Patch
M examples/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D examples/embedded_app/BUILD.gn View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
D examples/embedded_app/embedded_app.cc View 1 2 3 1 chunk +0 lines, -118 lines 0 comments Download
M mojo/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/BUILD.gn View 1 2 3 1 chunk +58 lines, -61 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/animations.mojom.dart View 1 2 3 1 chunk +0 lines, -511 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/view_manager.mojom.dart View 1 2 3 1 chunk +0 lines, -4628 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/window_manager.mojom.dart View 1 2 3 1 chunk +0 lines, -1455 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/window_manager_internal.mojom.dart View 1 2 3 1 chunk +0 lines, -753 lines 0 comments Download
M mojo/nacl/BUILD.gn View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/mojo_services.gni View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/services/view_manager/cpp/BUILD.gn View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/view_manager/cpp/keys.h View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/view_manager/cpp/keys.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view.cc View 1 2 3 1 chunk +0 lines, -581 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_manager_client_factory.cc View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_manager_client_impl.h View 1 2 3 1 chunk +0 lines, -164 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_manager_client_impl.cc View 1 2 3 1 chunk +0 lines, -494 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_manager_context.cc View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_observer.cc View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_private.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/services/view_manager/cpp/lib/view_private.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/view_manager/cpp/tests/BUILD.gn View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/view_manager/cpp/tests/run_all_unittests.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/view_manager/cpp/tests/view_manager_test_suite.h View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/services/view_manager/cpp/tests/view_manager_test_suite.cc View 1 2 3 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/services/view_manager/cpp/tests/view_unittest.cc View 1 2 3 1 chunk +0 lines, -874 lines 0 comments Download
D mojo/services/view_manager/cpp/types.h View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/view_manager/cpp/util.h View 1 2 3 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/view_manager/cpp/view.h View 1 2 3 1 chunk +0 lines, -214 lines 0 comments Download
D mojo/services/view_manager/cpp/view_manager.h View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/view_manager/cpp/view_manager_client_factory.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/services/view_manager/cpp/view_manager_context.h View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/view_manager/cpp/view_manager_delegate.h View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/services/view_manager/cpp/view_manager_delegate.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/view_manager/cpp/view_observer.h View 1 2 3 1 chunk +0 lines, -105 lines 0 comments Download
D mojo/services/view_manager/cpp/view_property.h View 1 2 3 1 chunk +0 lines, -139 lines 0 comments Download
D mojo/services/view_manager/cpp/view_tracker.h View 1 2 3 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/view_manager/cpp/view_tracker.cc View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/services/view_manager/interfaces/BUILD.gn View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/view_manager/interfaces/animations.mojom View 1 2 3 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/view_manager/interfaces/view_manager.mojom View 1 2 3 1 chunk +0 lines, -233 lines 0 comments Download
D mojo/services/view_manager/interfaces/view_manager_constants.mojom View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/services/window_manager/interfaces/BUILD.gn View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/services/window_manager/interfaces/window_manager.mojom View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/services/window_manager/interfaces/window_manager_internal.mojom View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
M services/BUILD.gn View 1 2 3 3 chunks +1 line, -14 lines 0 comments Download
D services/kiosk_wm/BUILD.gn View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
D services/kiosk_wm/README.md View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
D services/kiosk_wm/kiosk_wm.h View 1 2 3 1 chunk +0 lines, -44 lines 0 comments Download
D services/kiosk_wm/kiosk_wm.cc View 1 2 3 1 chunk +0 lines, -44 lines 0 comments Download
D services/kiosk_wm/kiosk_wm_controller.h View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D services/kiosk_wm/kiosk_wm_controller.cc View 1 2 3 1 chunk +0 lines, -109 lines 0 comments Download
D services/kiosk_wm/main.cc View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
D services/kiosk_wm/merged_service_provider.h View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
D services/kiosk_wm/merged_service_provider.cc View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D services/kiosk_wm/navigator_host_impl.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D services/kiosk_wm/navigator_host_impl.cc View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
D services/view_manager/BUILD.gn View 1 2 3 1 chunk +0 lines, -196 lines 0 comments Download
D services/view_manager/access_policy.h View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D services/view_manager/access_policy_delegate.h View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D services/view_manager/animation_runner.h View 1 2 3 1 chunk +0 lines, -114 lines 0 comments Download
D services/view_manager/animation_runner.cc View 1 2 3 1 chunk +0 lines, -156 lines 0 comments Download
D services/view_manager/animation_runner_observer.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D services/view_manager/animation_runner_unittest.cc View 1 2 3 1 chunk +0 lines, -636 lines 0 comments Download
D services/view_manager/client_connection.h View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
D services/view_manager/client_connection.cc View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D services/view_manager/connection_manager.h View 1 2 3 1 chunk +0 lines, -252 lines 0 comments Download
D services/view_manager/connection_manager.cc View 1 2 3 1 chunk +0 lines, -507 lines 0 comments Download
D services/view_manager/connection_manager_delegate.h View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D services/view_manager/default_access_policy.h View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D services/view_manager/default_access_policy.cc View 1 2 3 1 chunk +0 lines, -112 lines 0 comments Download
D services/view_manager/display_manager.h View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
D services/view_manager/display_manager.cc View 1 2 3 1 chunk +0 lines, -181 lines 0 comments Download
D services/view_manager/focus_controller.h View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D services/view_manager/focus_controller.cc View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
D services/view_manager/focus_controller_delegate.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D services/view_manager/focus_controller_unittest.cc View 1 2 3 1 chunk +0 lines, -106 lines 0 comments Download
D services/view_manager/gesture_manager.h View 1 2 3 1 chunk +0 lines, -188 lines 0 comments Download
D services/view_manager/gesture_manager.cc View 1 2 3 1 chunk +0 lines, -701 lines 0 comments Download
D services/view_manager/gesture_manager_delegate.h View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
D services/view_manager/gesture_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -467 lines 0 comments Download
D services/view_manager/ids.h View 1 2 3 1 chunk +0 lines, -62 lines 0 comments Download
D services/view_manager/main.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
D services/view_manager/scheduled_animation_group.h View 1 2 3 1 chunk +0 lines, -110 lines 0 comments Download
D services/view_manager/scheduled_animation_group.cc View 1 2 3 1 chunk +0 lines, -348 lines 0 comments Download
D services/view_manager/scheduled_animation_group_unittest.cc View 1 2 3 1 chunk +0 lines, -94 lines 0 comments Download
D services/view_manager/server_view.h View 1 2 3 1 chunk +0 lines, -120 lines 0 comments Download
D services/view_manager/server_view.cc View 1 2 3 1 chunk +0 lines, -234 lines 0 comments Download
D services/view_manager/server_view_delegate.h View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
D services/view_manager/server_view_drawn_tracker.h View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D services/view_manager/server_view_drawn_tracker.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D services/view_manager/server_view_drawn_tracker_observer.h View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D services/view_manager/server_view_drawn_tracker_unittest.cc View 1 2 3 1 chunk +0 lines, -136 lines 0 comments Download
D services/view_manager/server_view_observer.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D services/view_manager/test_change_tracker.h View 1 2 3 1 chunk +0 lines, -157 lines 0 comments Download
D services/view_manager/test_change_tracker.cc View 1 2 3 1 chunk +0 lines, -314 lines 0 comments Download
D services/view_manager/test_server_view_delegate.h View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D services/view_manager/test_server_view_delegate.cc View 1 2 3 1 chunk +0 lines, -30 lines 0 comments Download
D services/view_manager/view_coordinate_conversions.h View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D services/view_manager/view_coordinate_conversions.cc View 1 2 3 1 chunk +0 lines, -69 lines 0 comments Download
D services/view_manager/view_coordinate_conversions_unittest.cc View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D services/view_manager/view_locator.h View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
D services/view_manager/view_locator.cc View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D services/view_manager/view_manager_app.h View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
D services/view_manager/view_manager_app.cc View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D services/view_manager/view_manager_client_apptest.cc View 1 2 3 1 chunk +0 lines, -653 lines 0 comments Download
D services/view_manager/view_manager_root_connection.h View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
D services/view_manager/view_manager_root_connection.cc View 1 2 3 1 chunk +0 lines, -139 lines 0 comments Download
D services/view_manager/view_manager_service_apptest.cc View 1 2 3 1 chunk +0 lines, -1496 lines 0 comments Download
D services/view_manager/view_manager_service_impl.h View 1 2 3 1 chunk +0 lines, -260 lines 0 comments Download
D services/view_manager/view_manager_service_impl.cc View 1 2 3 1 chunk +0 lines, -656 lines 0 comments Download
D services/view_manager/view_manager_service_unittest.cc View 1 2 3 1 chunk +0 lines, -471 lines 0 comments Download
D services/view_manager/window_manager_access_policy.h View 1 2 3 1 chunk +0 lines, -52 lines 0 comments Download
D services/view_manager/window_manager_access_policy.cc View 1 2 3 1 chunk +0 lines, -97 lines 0 comments Download
D services/window_manager/BUILD.gn View 1 2 3 1 chunk +0 lines, -130 lines 0 comments Download
D services/window_manager/basic_focus_rules.h View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D services/window_manager/basic_focus_rules.cc View 1 2 3 1 chunk +0 lines, -171 lines 0 comments Download
D services/window_manager/capture_controller.h View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D services/window_manager/capture_controller.cc View 1 2 3 1 chunk +0 lines, -103 lines 0 comments Download
D services/window_manager/capture_controller_observer.h View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
D services/window_manager/focus_controller.h View 1 2 3 1 chunk +0 lines, -102 lines 0 comments Download
D services/window_manager/focus_controller.cc View 1 2 3 1 chunk +0 lines, -317 lines 0 comments Download
D services/window_manager/focus_controller_observer.h View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D services/window_manager/focus_controller_unittest.cc View 1 2 3 1 chunk +0 lines, -1197 lines 0 comments Download
D services/window_manager/focus_rules.h View 1 2 3 1 chunk +0 lines, -65 lines 0 comments Download
D services/window_manager/hit_test.h View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
D services/window_manager/main.cc View 1 2 3 1 chunk +0 lines, -108 lines 0 comments Download
D services/window_manager/native_viewport_event_dispatcher_impl.h View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
D services/window_manager/run_all_unittests.cc View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D services/window_manager/view_event_dispatcher.h View 1 2 3 1 chunk +0 lines, -47 lines 0 comments Download
D services/window_manager/view_event_dispatcher.cc View 1 2 3 1 chunk +0 lines, -55 lines 0 comments Download
D services/window_manager/view_target.h View 1 2 3 1 chunk +0 lines, -100 lines 0 comments Download
D services/window_manager/view_target.cc View 1 2 3 1 chunk +0 lines, -167 lines 0 comments Download
D services/window_manager/view_target_unittest.cc View 1 2 3 1 chunk +0 lines, -81 lines 0 comments Download
D services/window_manager/view_targeter.h View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D services/window_manager/view_targeter.cc View 1 2 3 1 chunk +0 lines, -148 lines 0 comments Download
D services/window_manager/view_targeter_unittest.cc View 1 2 3 1 chunk +0 lines, -114 lines 0 comments Download
D services/window_manager/window_manager_app.h View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D services/window_manager/window_manager_app.cc View 1 2 3 1 chunk +0 lines, -64 lines 0 comments Download
D services/window_manager/window_manager_apptest.cc View 1 2 3 1 chunk +0 lines, -212 lines 0 comments Download
D services/window_manager/window_manager_delegate.h View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
D services/window_manager/window_manager_impl.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D services/window_manager/window_manager_impl.cc View 1 2 3 1 chunk +0 lines, -94 lines 0 comments Download
D services/window_manager/window_manager_root.h View 1 2 3 1 chunk +0 lines, -200 lines 0 comments Download
D services/window_manager/window_manager_root.cc View 1 2 3 1 chunk +0 lines, -413 lines 0 comments Download
D services/window_manager/window_manager_root_android.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
D services/window_manager/window_manager_root_linux.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
D services/window_manager/window_manager_test_util.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D services/window_manager/window_manager_test_util.cc View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
M shell/BUILD.gn View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M shell/android/main.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
jeffbrown
5 years ago (2015-12-17 22:00:03 UTC) #1
viettrungluu
I think you'll need to remove some stuff in mojo/tools/data/{apptests,unittests} too. (Sadly, everything would probably ...
5 years ago (2015-12-17 22:57:00 UTC) #2
jeffbrown
On 2015/12/17 22:57:00, viettrungluu wrote: > I think you'll need to remove some stuff in ...
5 years ago (2015-12-17 22:59:22 UTC) #3
viettrungluu
On 2015/12/17 22:59:22, jeffbrown wrote: > On 2015/12/17 22:57:00, viettrungluu wrote: > > I think ...
5 years ago (2015-12-17 23:06:07 UTC) #4
abarth
LGTM assuming clean builds pass tests.
4 years, 11 months ago (2016-01-10 01:02:42 UTC) #5
jeffbrown
rebase
4 years, 11 months ago (2016-01-26 08:49:03 UTC) #6
jeffbrown
4 years, 11 months ago (2016-01-26 23:48:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:30001) manually as
c837be78d25cb96843171f3f3f982bffd0dabed5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698