Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1536863002: Delete the Surfaces service. (Closed)

Created:
5 years ago by jeffbrown
Modified:
4 years, 11 months ago
Reviewers:
abarth, viettrungluu, jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-4
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete the Surfaces service. This service has been superceded by the Mozart compositor. BUG= Review URL: https://codereview.chromium.org/1534693002 . R=abarth@google.com, abarth, jamesr, viettrungluu Committed: https://chromium.googlesource.com/external/mojo/+/d1338e7457cb905801b6c300f0d74860e82c631d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3905 lines) Patch
D examples/bitmap_uploader/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
D examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +0 lines, -78 lines 0 comments Download
D examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +0 lines, -276 lines 0 comments Download
D examples/surfaces_app/BUILD.gn View 1 chunk +0 lines, -142 lines 0 comments Download
D examples/surfaces_app/child.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
D examples/surfaces_app/child_app.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D examples/surfaces_app/child_gl_app.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D examples/surfaces_app/child_gl_impl.h View 1 chunk +0 lines, -74 lines 0 comments Download
D examples/surfaces_app/child_gl_impl.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D examples/surfaces_app/child_impl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D examples/surfaces_app/child_impl.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D examples/surfaces_app/embedder.h View 1 chunk +0 lines, -40 lines 0 comments Download
D examples/surfaces_app/embedder.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D examples/surfaces_app/surfaces_app.cc View 1 chunk +0 lines, -128 lines 0 comments Download
D examples/surfaces_app/surfaces_util.h View 1 chunk +0 lines, -27 lines 0 comments Download
D examples/surfaces_app/surfaces_util.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M mojo/BUILD.gn View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/converters/surfaces/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +0 lines, -147 lines 0 comments Download
D mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +0 lines, -590 lines 0 comments Download
D mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/converters/surfaces/tests/surface_unittest.cc View 1 chunk +0 lines, -467 lines 0 comments Download
M mojo/services/native_viewport/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/BUILD.gn View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
D services/fake_surfaces/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D services/fake_surfaces/fake_surfaces_service_application.h View 1 chunk +0 lines, -51 lines 0 comments Download
D services/fake_surfaces/fake_surfaces_service_application.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D services/surfaces/BUILD.gn View 1 chunk +0 lines, -48 lines 0 comments Download
D services/surfaces/context_provider_mojo.h View 1 chunk +0 lines, -69 lines 0 comments Download
D services/surfaces/context_provider_mojo.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D services/surfaces/display_factory_impl.h View 1 chunk +0 lines, -44 lines 0 comments Download
D services/surfaces/display_factory_impl.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D services/surfaces/display_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D services/surfaces/display_impl.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D services/surfaces/surfaces_impl.h View 1 chunk +0 lines, -67 lines 0 comments Download
D services/surfaces/surfaces_impl.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D services/surfaces/surfaces_output_surface.h View 1 chunk +0 lines, -29 lines 0 comments Download
D services/surfaces/surfaces_output_surface.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D services/surfaces/surfaces_scheduler.h View 1 chunk +0 lines, -58 lines 0 comments Download
D services/surfaces/surfaces_scheduler.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D services/surfaces/surfaces_service_application.h View 1 chunk +0 lines, -55 lines 0 comments Download
D services/surfaces/surfaces_service_application.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M shell/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1531403003 Patch 30001

Dependent Patchsets:

Issue 1535833002 Patch 10001

Messages

Total messages: 5 (1 generated)
jeffbrown
5 years ago (2015-12-17 22:00:38 UTC) #1
abarth
LGTM
4 years, 11 months ago (2016-01-10 01:00:29 UTC) #2
jeffbrown
rebase
4 years, 11 months ago (2016-01-26 08:52:02 UTC) #3
jeffbrown
4 years, 11 months ago (2016-01-26 23:48:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
d1338e7457cb905801b6c300f0d74860e82c631d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698