Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1516753008: Subzero: Use "auto" per (unwritten) auto coding style. (Closed)

Created:
5 years ago by Jim Stichnoth
Modified:
5 years ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use "auto" per (unwritten) auto coding style. auto *Foo = llvm::cast<Foo>(...) auto *Foo = llvm::dyn_cast<Foo>(...) auto *Foo = llvm::dyn_cast_or_null<Foo>(...) auto *Foo = Foo::create(...) Some instances may have been missed due to line breaks or "const" mismatches. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=54f3d518805b04b3f2958b7906a7d07dedb4e1ae

Patch Set 1 #

Patch Set 2 : More <cast> instances without the llvm:: prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -116 lines) Patch
M src/IceCfg.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/IceCfgNode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/IceConverter.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInst.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceInstARM32.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M src/IceInstMIPS32.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/IceOperand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IcePhiLoweringImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 16 chunks +22 lines, -22 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 36 chunks +50 lines, -50 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jim Stichnoth
5 years ago (2015-12-11 14:49:20 UTC) #4
Karl
lgtm
5 years ago (2015-12-11 16:52:22 UTC) #5
Jim Stichnoth
5 years ago (2015-12-11 17:53:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
54f3d518805b04b3f2958b7906a7d07dedb4e1ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698