src/IceTargetLoweringX8664.cpp - Issue 1516753008: Subzero: Use "auto" per (unwritten) auto coding style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8664.cpp

Issue 1516753008: Subzero: Use "auto" per (unwritten) auto coding style. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: More <cast> instances without the llvm:: prefix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8664.cpp

diff --git a/src/IceTargetLoweringX8664.cpp b/src/IceTargetLoweringX8664.cpp

index ceaaede2e46e5b4d4dcc172e1b03300913fe83e5..1ef6c43274562cd84e036326eaf7bacc0cf8b831 100644

--- a/src/IceTargetLoweringX8664.cpp

+++ b/src/IceTargetLoweringX8664.cpp

@@ -783,7 +783,7 @@ void TargetDataX8664::emitConstantPool(GlobalContext *Ctx) {

for (Constant *C : Pool) {

if (!C->getShouldBePooled())

continue;

- typename T::IceType *Const = llvm::cast<typename T::IceType>(C);

+ auto *Const = llvm::cast<typename T::IceType>(C);

typename T::IceType::PrimType Value = Const->getValue();

// Use memcpy() to copy bits from Value into RawValue in a way that avoids

// breaking strict-aliasing rules.

« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | src/IceTargetLoweringX86BaseImpl.h » ('j') | no next file with comments »