Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1512823004: Move DistanceAdjustTable to its own file (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext7
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move DistanceAdjustTable to its own file BUG=skia: Committed: https://skia.googlesource.com/skia/+/1acabf3787bdaccd70ed53e64b3957d27ea34f79

Patch Set 1 #

Patch Set 2 : also move batch test to the batch file #

Patch Set 3 : undo move to own file #

Patch Set 4 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -111 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 2 2 chunks +2 lines, -21 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 2 2 chunks +1 line, -84 lines 0 comments Download
A src/gpu/GrDistanceFieldAdjustTable.h View 1 chunk +31 lines, -0 lines 0 comments Download
A src/gpu/GrDistanceFieldAdjustTable.cpp View 1 chunk +93 lines, -0 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 2 4 chunks +7 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1517563002 Patch 80001

Dependent Patchsets:

Issue 1518763002 Patch 1
Issue 1518763002 Patch 20001
Issue 1518763002 Patch 40001

Messages

Total messages: 8 (4 generated)
joshualitt
Just a code move to facilitate sharing this object without everyone getting all friendly.
5 years ago (2015-12-09 21:34:02 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-09 21:37:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512823004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512823004/60001
5 years ago (2015-12-10 16:56:43 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 17:10:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/1acabf3787bdaccd70ed53e64b3957d27ea34f79

Powered by Google App Engine
This is Rietveld 408576698