Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518763002: Move flush logic into GrAtlasTextBlob (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext8
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : some more tweaks #

Patch Set 3 : silence compiler warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -205 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextBlob.h View 1 2 4 chunks +65 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextBlob.cpp View 1 2 chunks +191 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 2 chunks +1 line, -23 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 6 chunks +9 lines, -179 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1512823004 Patch 60001

Dependent Patchsets:

Issue 1514933002 Patch 1

Messages

Total messages: 17 (9 generated)
joshualitt
entirely a code move, I think I will do a follow on at some point ...
5 years ago (2015-12-10 18:37:46 UTC) #2
jvanverth1
lgtm
5 years ago (2015-12-10 18:50:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518763002/20001
5 years ago (2015-12-10 18:54:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4759) skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, ...
5 years ago (2015-12-10 18:55:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518763002/40001
5 years ago (2015-12-10 19:10:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4607)
5 years ago (2015-12-10 19:11:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518763002/40001
5 years ago (2015-12-10 19:21:02 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-10 19:22:11 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2e2202e95e44bb55a097cb57b020af690ae5cdd6

Powered by Google App Engine
This is Rietveld 408576698