Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517563002: Move appending of large glyphs into GrAtlasTextBlob (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext6
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move appending of large glyphs into GrAtlasTextBlob BUG=skia: Committed: https://skia.googlesource.com/skia/+/a06e6ab3fafb8c8712bc296f72c3f8b88856f1fe

Patch Set 1 #

Patch Set 2 : move a bit more into GrAtlasTextBlob #

Patch Set 3 : remove a bit more code #

Total comments: 1

Patch Set 4 : a little privacy #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M src/gpu/GrAtlasTextBlob.h View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M src/gpu/GrAtlasTextBlob.cpp View 1 2 3 4 2 chunks +23 lines, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 2 chunks +4 lines, -30 lines 0 comments Download

Depends on Patchset:

Issue 1515543003 Patch 20001

Dependent Patchsets:

Issue 1512823004 Patch 60001

Messages

Total messages: 8 (4 generated)
joshualitt
Just moving a bit more into GrAtlasTextBlob
5 years ago (2015-12-09 20:30:22 UTC) #2
bsalomon
https://codereview.chromium.org/1517563002/diff/40001/src/gpu/GrAtlasTextBlob.h File src/gpu/GrAtlasTextBlob.h (right): https://codereview.chromium.org/1517563002/diff/40001/src/gpu/GrAtlasTextBlob.h#newcode293 src/gpu/GrAtlasTextBlob.h:293: void appendLargeGlyph(GrGlyph* glyph, GrFontScaler* scaler, const SkGlyph& skGlyph, can ...
5 years ago (2015-12-09 20:49:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517563002/80001
5 years ago (2015-12-10 16:03:05 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 16:54:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a06e6ab3fafb8c8712bc296f72c3f8b88856f1fe

Powered by Google App Engine
This is Rietveld 408576698