Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1512803004: Use refs for GraphicsContext (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, caseq+blink_chromium.org, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, danakj, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, rwlbuis, vmpstr+blinkwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, jbroman, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, sergeyv+blink_chromium.org, ajuma+watch-canvas_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ScrollbarTheme
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use refs for GraphicsContext Committed: https://crrev.com/a734170517b9576bedce9feeddfe53473510c4e9 Cr-Commit-Position: refs/heads/master@{#364486}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 3

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+984 lines, -988 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.cpp View 8 chunks +15 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp View 1 8 chunks +17 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPartTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.h View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 23 chunks +49 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 26 chunks +52 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipScope.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FileUploadControlPainter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FrameSetPainter.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/HTMLCanvasPainter.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 4 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 7 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 20 chunks +46 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 7 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 6 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 10 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.h View 3 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfoTest.cpp View 1 6 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.h View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 27 chunks +41 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 5 chunks +17 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 6 chunks +12 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 10 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp View 3 chunks +12 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 2 3 4 5 8 chunks +32 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 7 chunks +18 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGTextPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 5 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainterTest.cpp View 1 3 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 13 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 2 3 4 16 chunks +55 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainter.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Theme.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContextStateSaver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/LocalCurrentGraphicsContext.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/LocalCurrentGraphicsContext.mm View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ThemeMac.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mac/ThemeMac.mm View 1 2 9 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFontImpl.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Xianzhu
You can just review the non-trivial changes noted below. https://codereview.chromium.org/1512803004/diff/80001/third_party/WebKit/Source/core/layout/ImageQualityController.h File third_party/WebKit/Source/core/layout/ImageQualityController.h (left): https://codereview.chromium.org/1512803004/diff/80001/third_party/WebKit/Source/core/layout/ImageQualityController.h#oldcode58 third_party/WebKit/Source/core/layout/ImageQualityController.h:58: ...
5 years ago (2015-12-10 16:55:36 UTC) #2
pdr.
On 2015/12/10 at 16:55:36, wangxianzhu wrote: > You can just review the non-trivial changes noted ...
5 years ago (2015-12-10 18:36:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512803004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512803004/100001
5 years ago (2015-12-10 19:39:37 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-10 21:45:26 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-10 21:46:13 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a734170517b9576bedce9feeddfe53473510c4e9
Cr-Commit-Position: refs/heads/master@{#364486}

Powered by Google App Engine
This is Rietveld 408576698