third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp - Issue 1512803004: Use refs for GraphicsContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp

Issue 1512803004: Use refs for GraphicsContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarTheme

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp b/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp

index 65d2b5b9498db8cfbd61c498f6657af388f77f04..1294970faa3806e8506b59b557ce481c4b223e6b 100644

--- a/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp

@@ -35,12 +35,12 @@ void SVGContainerPainter::paint(const PaintInfo& paintInfo)

PaintInfo paintInfoBeforeFiltering(paintInfo);

paintInfoBeforeFiltering.updateCullRect(m_layoutSVGContainer.localToParentTransform());

- TransformRecorder transformRecorder(*paintInfoBeforeFiltering.context, m_layoutSVGContainer, m_layoutSVGContainer.localToParentTransform());

+ TransformRecorder transformRecorder(paintInfoBeforeFiltering.context, m_layoutSVGContainer, m_layoutSVGContainer.localToParentTransform());

{

Optional<FloatClipRecorder> clipRecorder;

if (m_layoutSVGContainer.isSVGViewportContainer() && SVGLayoutSupport::isOverflowHidden(&m_layoutSVGContainer)) {

FloatRect viewport = m_layoutSVGContainer.localToParentTransform().inverse().mapRect(toLayoutSVGViewportContainer(m_layoutSVGContainer).viewport());

- clipRecorder.emplace(*paintInfoBeforeFiltering.context, m_layoutSVGContainer, paintInfoBeforeFiltering.phase, viewport);

+ clipRecorder.emplace(paintInfoBeforeFiltering.context, m_layoutSVGContainer, paintInfoBeforeFiltering.phase, viewport);

}

SVGPaintContext paintContext(m_layoutSVGContainer, paintInfoBeforeFiltering);