Follow macro invocations when checking if a violation happened in a .cc file.

Follow macro invocations when checking if a violation happened in a .cc file.

BUG=156590
Committed: https://crrev.com/dde9ba7081ac3a9bd052d819d1467af82e836866
Cr-Commit-Position: refs/heads/master@{#364385}

[Jeffrey Yasskin, 2015-12-10 02:02:05]

jyasskin@chromium.org changed reviewers:
+ thakis@chromium.org

[Jeffrey Yasskin, 2015-12-10 02:02:16]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 02:03:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504033010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504033010/1

[Jeffrey Yasskin, 2015-12-10 02:16:15]

This one successfully builds everything on my linux box with no cleanup.

[commit-bot: I haz the power, 2015-12-10 04:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 04:05:46]

Dry run: This issue passed the CQ dry run.

[Jeffrey Yasskin, 2015-12-10 04:19:20]

https://codereview.chromium.org/1504033010/diff/1/tools/clang/plugins/ChromeC...
File tools/clang/plugins/ChromeClassTester.cpp (right):

https://codereview.chromium.org/1504033010/diff/1/tools/clang/plugins/ChromeC...
tools/clang/plugins/ChromeClassTester.cpp:194: record_location =
source_manager.getExpansionRange(record_location).first;
I thought I could just go to the outermost macro and check that, but there are
preprocessor programs that defeat it:

../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h:33:1:
error: [chromium-style] Complex constructor has an inlined body.
../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h:30:32:
note: expanded from macro 'TEST_ALL_EVENTS'
#define TEST_ALL_EVENTS(state) TEST_ALL_EVENTS_NON_METRO(state)
                               ^
../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h:22:5:
note: expanded from macro 'TEST_ALL_EVENTS_NON_METRO'
    TEST_EVENT(state, WINDOW_CHANGE)
    ^
../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_interactive_browsertest.cc:71:3:
note: expanded from macro 'TEST_EVENT'
  IN_PROC_BROWSER_TEST_F(FullscreenControllerStateInteractiveTest, \
  ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see
all)
../../content/public/test/browser_test.h:24:5: note: expanded from macro
'IN_PROC_BROWSER_TEST_'
    GTEST_TEST_CLASS_NAME_(test_case_name, test_name)() {}                   \
    ^
../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note:
expanded from macro 'GTEST_TEST_CLASS_NAME_'
  test_case_name##_##test_name##_Test
  ^
<scratch space>:32:1: note: expanded from here
FullscreenControllerStateInteractiveTest_DISABLED_STATE_NORMAL__WINDOW_CHANGE_Test
^

[Nico, 2015-12-10 14:22:35]

looks great, thanks! lgtm

https://codereview.chromium.org/1504033010/diff/20001/tools/clang/plugins/tes...
File tools/clang/plugins/tests/inline_ctor.h (right):

https://codereview.chromium.org/1504033010/diff/20001/tools/clang/plugins/tes...
tools/clang/plugins/tests/inline_ctor.h:32: MACRO_FROM_CPP;
Do we need the "macro defined in cpp file but used in header" in practice? Maybe
for the ipc message generation macros? Feels a bit strange to allow this (but
seems obscure enough to not matter for almost all files)

[Jeffrey Yasskin, 2015-12-10 16:20:00]

Thanks!

https://codereview.chromium.org/1504033010/diff/20001/tools/clang/plugins/tes...
File tools/clang/plugins/tests/inline_ctor.h (right):

https://codereview.chromium.org/1504033010/diff/20001/tools/clang/plugins/tes...
tools/clang/plugins/tests/inline_ctor.h:32: MACRO_FROM_CPP;
On 2015/12/10 14:22:35, Nico wrote:
> Do we need the "macro defined in cpp file but used in header" in practice?
Maybe
> for the ipc message generation macros? Feels a bit strange to allow this (but
> seems obscure enough to not matter for almost all files)

It's pretty obscure, but the inline-virtuals patch needs it for
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui....

[Jeffrey Yasskin, 2015-12-10 16:48:05]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2015-12-10 16:48:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504033010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504033010/20001

[commit-bot: I haz the power, 2015-12-10 17:00:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 17:01:39]

Description was changed from

==========
Follow macro invocations when checking if a violation happened in a .cc file.

BUG=156590
==========

to

==========
Follow macro invocations when checking if a violation happened in a .cc file.

BUG=156590

Committed: https://crrev.com/dde9ba7081ac3a9bd052d819d1467af82e836866
Cr-Commit-Position: refs/heads/master@{#364385}
==========

[commit-bot: I haz the power, 2015-12-10 17:01:39]

Patchset 2 (id:??) landed as
https://crrev.com/dde9ba7081ac3a9bd052d819d1467af82e836866
Cr-Commit-Position: refs/heads/master@{#364385}