Follow macro invocations when checking if a violation happened in a .cc file.

tools/clang/plugins/tests/inline_ctor.h

Index: tools/clang/plugins/tests/inline_ctor.h
diff --git a/tools/clang/plugins/tests/inline_ctor.h b/tools/clang/plugins/tests/inline_ctor.h
index 1ab1589c87979f473a94710afbdb31ca48e65140..2b9beb974ee9aa1027f384a6b8eb096d3376b526 100644
--- a/tools/clang/plugins/tests/inline_ctor.h
+++ b/tools/clang/plugins/tests/inline_ctor.h
@@ -18,6 +18,19 @@ class InlineCtorsArentOKInHeader {
   std::vector<std::string> two_;
 };
 
+#define INLINE_CTORS_IN_A_MACRO(CLASS_NAME) \
+  class CLASS_NAME {                        \
+   public:                                  \
+    CLASS_NAME() {}                         \
+    ~CLASS_NAME() {}                        \
+                                            \
+   private:                                 \
+    std::vector<int> one_;                  \
+    std::vector<std::string> two_;          \
+  }
+INLINE_CTORS_IN_A_MACRO(InlineCtorsBehindAMacroArentOKInHeader);
+MACRO_FROM_CPP;

[Nico, 2015/12/10 14:22:35]

Do we need the "macro defined in cpp file but used in header" in practice? Maybe
for the ipc message generation macros? Feels a bit strange to allow this (but
seems obscure enough to not matter for almost all files)

[Jeffrey Yasskin, 2015/12/10 16:20:00]

It's pretty obscure, but the inline-virtuals patch needs it for
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui....

+
 class DeletedMembersInHeaderAreOKThough {
  public:
   DeletedMembersInHeaderAreOKThough() = delete;