Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/clang/plugins/tests/inline_ctor.txt

Issue 1504033010: Follow macro invocations when checking if a violation happened in a .cc file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Check every file in the macro instantiation chain. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 In file included from inline_ctor.cpp:5: 1 In file included from inline_ctor.cpp:7:
2 ./inline_ctor.h:13:3: warning: [chromium-style] Complex constructor has an inlin ed body. 2 ./inline_ctor.h:13:3: warning: [chromium-style] Complex constructor has an inlin ed body.
3 InlineCtorsArentOKInHeader() {} 3 InlineCtorsArentOKInHeader() {}
4 ^ 4 ^
5 ./inline_ctor.h:14:3: warning: [chromium-style] Complex destructor has an inline body. 5 ./inline_ctor.h:14:3: warning: [chromium-style] Complex destructor has an inline body.
6 ~InlineCtorsArentOKInHeader() {} 6 ~InlineCtorsArentOKInHeader() {}
7 ^ 7 ^
8 ./inline_ctor.h:82:1: warning: [chromium-style] Complex class/struct needs an ex plicit out-of-line constructor. 8 ./inline_ctor.h:31:25: warning: [chromium-style] Complex constructor has an inli ned body.
9 INLINE_CTORS_IN_A_MACRO(InlineCtorsBehindAMacroArentOKInHeader);
10 ^
11 ./inline_ctor.h:31:1: warning: [chromium-style] Complex destructor has an inline body.
12 INLINE_CTORS_IN_A_MACRO(InlineCtorsBehindAMacroArentOKInHeader);
13 ^
14 ./inline_ctor.h:25:5: note: expanded from macro 'INLINE_CTORS_IN_A_MACRO'
15 ~CLASS_NAME() {} \
16 ^
17 ./inline_ctor.h:95:1: warning: [chromium-style] Complex class/struct needs an ex plicit out-of-line constructor.
9 struct FourNonTrivialMembers { 18 struct FourNonTrivialMembers {
10 ^ 19 ^
11 ./inline_ctor.h:82:1: warning: [chromium-style] Complex class/struct needs an ex plicit out-of-line destructor. 20 ./inline_ctor.h:95:1: warning: [chromium-style] Complex class/struct needs an ex plicit out-of-line destructor.
12 4 warnings generated. 21 6 warnings generated.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698