Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 1504033010: Follow macro invocations when checking if a violation happened in a .cc file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Check every file in the macro instantiation chain. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "FindBadConstructsAction.h" 5 #include "FindBadConstructsAction.h"
6 6
7 #include "clang/AST/ASTConsumer.h" 7 #include "clang/AST/ASTConsumer.h"
8 #include "clang/Frontend/FrontendPluginRegistry.h" 8 #include "clang/Frontend/FrontendPluginRegistry.h"
9 9
10 #include "FindBadConstructsConsumer.h" 10 #include "FindBadConstructsConsumer.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 } else if (args[i] == "enforce-in-thirdparty-webkit") { 52 } else if (args[i] == "enforce-in-thirdparty-webkit") {
53 options_.enforce_in_thirdparty_webkit = true; 53 options_.enforce_in_thirdparty_webkit = true;
54 } else if (args[i] == "check-enum-last-value") { 54 } else if (args[i] == "check-enum-last-value") {
55 // TODO(tsepez): Enable this by default once http://crbug.com/356815 55 // TODO(tsepez): Enable this by default once http://crbug.com/356815
56 // and http://crbug.com/356816 are fixed. 56 // and http://crbug.com/356816 are fixed.
57 options_.check_enum_last_value = true; 57 options_.check_enum_last_value = true;
58 } else if (args[i] == "with-ast-visitor") { 58 } else if (args[i] == "with-ast-visitor") {
59 options_.with_ast_visitor = true; 59 options_.with_ast_visitor = true;
60 } else if (args[i] == "check-templates") { 60 } else if (args[i] == "check-templates") {
61 options_.check_templates = true; 61 options_.check_templates = true;
62 } else if (args[i] == "follow-macro-expansion") {
63 options_.follow_macro_expansion = true;
62 } else { 64 } else {
63 parsed = false; 65 parsed = false;
64 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n"; 66 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
65 } 67 }
66 } 68 }
67 69
68 return parsed; 70 return parsed;
69 } 71 }
70 72
71 } // namespace chrome_checker 73 } // namespace chrome_checker
72 74
73 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( 75 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
74 "find-bad-constructs", 76 "find-bad-constructs",
75 "Finds bad C++ constructs"); 77 "Finds bad C++ constructs");
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698