Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/clang/plugins/tests/inline_ctor.txt

Issue 1504033010: Follow macro invocations when checking if a violation happened in a .cc file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Check every file in the macro instantiation chain. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/inline_ctor.txt
diff --git a/tools/clang/plugins/tests/inline_ctor.txt b/tools/clang/plugins/tests/inline_ctor.txt
index bd2c53bc5ee05dce8db1e98c130d4fd7fc29ac3d..7ca06296d2f5fe7dd53f4548eaaf792d62dd341d 100644
--- a/tools/clang/plugins/tests/inline_ctor.txt
+++ b/tools/clang/plugins/tests/inline_ctor.txt
@@ -1,12 +1,21 @@
-In file included from inline_ctor.cpp:5:
+In file included from inline_ctor.cpp:7:
./inline_ctor.h:13:3: warning: [chromium-style] Complex constructor has an inlined body.
InlineCtorsArentOKInHeader() {}
^
./inline_ctor.h:14:3: warning: [chromium-style] Complex destructor has an inline body.
~InlineCtorsArentOKInHeader() {}
^
-./inline_ctor.h:82:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
+./inline_ctor.h:31:25: warning: [chromium-style] Complex constructor has an inlined body.
+INLINE_CTORS_IN_A_MACRO(InlineCtorsBehindAMacroArentOKInHeader);
+ ^
+./inline_ctor.h:31:1: warning: [chromium-style] Complex destructor has an inline body.
+INLINE_CTORS_IN_A_MACRO(InlineCtorsBehindAMacroArentOKInHeader);
+^
+./inline_ctor.h:25:5: note: expanded from macro 'INLINE_CTORS_IN_A_MACRO'
+ ~CLASS_NAME() {} \
+ ^
+./inline_ctor.h:95:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
struct FourNonTrivialMembers {
^
-./inline_ctor.h:82:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
-4 warnings generated.
+./inline_ctor.h:95:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
+6 warnings generated.

Powered by Google App Engine
This is Rietveld 408576698