Follow macro invocations when checking if a violation happened in a .cc file.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <algorithm>
@@ skipping 170 matching lines @@
   }
 
   return false;
 }
 
 std::string ChromeClassTester::GetNamespace(const Decl* record) {
   return GetNamespaceImpl(record->getDeclContext(), "");
 }
 
 bool ChromeClassTester::InImplementationFile(SourceLocation record_location) {
+  if (options_.follow_macro_expansion) {
+    // If |record_location| is a macro, check where it was called.
+    const SourceManager& source_manager = instance_.getSourceManager();
+    record_location = source_manager.getExpansionRange(record_location).first;

[Jeffrey Yasskin, 2015/12/10 04:19:20]

I thought I could just go to the outermost macro and check that, but there are
preprocessor programs that defeat it:

../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h:33:1:
error: [chromium-style] Complex constructor has an inlined body.
../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h:30:32:
note: expanded from macro 'TEST_ALL_EVENTS'
#define TEST_ALL_EVENTS(state) TEST_ALL_EVENTS_NON_METRO(state)
                               ^
../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_tests.h:22:5:
note: expanded from macro 'TEST_ALL_EVENTS_NON_METRO'
    TEST_EVENT(state, WINDOW_CHANGE)
    ^
../../chrome/browser/ui/exclusive_access/fullscreen_controller_state_interactive_browsertest.cc:71:3:
note: expanded from macro 'TEST_EVENT'
  IN_PROC_BROWSER_TEST_F(FullscreenControllerStateInteractiveTest, \
  ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see
all)
../../content/public/test/browser_test.h:24:5: note: expanded from macro
'IN_PROC_BROWSER_TEST_'
    GTEST_TEST_CLASS_NAME_(test_case_name, test_name)() {}                   \
    ^
../../testing/gtest/include/gtest/internal/gtest-internal.h:1211:3: note:
expanded from macro 'GTEST_TEST_CLASS_NAME_'
  test_case_name##_##test_name##_Test
  ^
<scratch space>:32:1: note: expanded from here
FullscreenControllerStateInteractiveTest_DISABLED_STATE_NORMAL__WINDOW_CHANGE_Test
^

+  }
+
   std::string filename;
   if (!GetFilename(record_location, &filename))
     return false;
 
   if (ends_with(filename, ".cc") || ends_with(filename, ".cpp") ||
       ends_with(filename, ".mm")) {
     return true;
   }
 
   return false;
@@ skipping 114 matching lines @@
   }
 
   *filename = ploc.getFilename();
   return true;
 }
 
 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
   return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
                                             : DiagnosticsEngine::Warning;
 }