Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1494793002: Rename recipes/ to fetch_configs/ (Closed)

Created:
5 years ago by luqui
Modified:
5 years ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename recipes/ to fetch_configs/ We are making depot_tools a proper (chromium) recipe package, which assumes that recipes are located in recipes/. So I need to move these other kinds of recipes out of the way. BUG=564920 R=dpranke@chromium.org, iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297837

Patch Set 1 #

Patch Set 2 : Renamed recipes to configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -1096 lines) Patch
M fetch.py View 1 7 chunks +29 lines, -28 lines 0 comments Download
A + fetch_configs/android.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + fetch_configs/breakpad.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + fetch_configs/chromium.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/config_util.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/crashpad.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + fetch_configs/dart.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/dartium.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/depot_tools.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/fletch.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/gyp.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/infra.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/infra_internal.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/ios.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + fetch_configs/mojo.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/nacl.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/naclports.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/pdfium.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + fetch_configs/skia.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/skia_buildbot.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/v8.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/webrtc.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + fetch_configs/webrtc_android.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + fetch_configs/webrtc_ios.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
D recipes/android.py View 1 chunk +0 lines, -34 lines 0 comments Download
D recipes/breakpad.py View 1 chunk +0 lines, -45 lines 0 comments Download
D recipes/chromium.py View 1 chunk +0 lines, -49 lines 0 comments Download
D recipes/crashpad.py View 1 chunk +0 lines, -41 lines 0 comments Download
D recipes/dart.py View 1 chunk +0 lines, -46 lines 0 comments Download
D recipes/dartium.py View 1 chunk +0 lines, -46 lines 0 comments Download
D recipes/depot_tools.py View 1 chunk +0 lines, -47 lines 0 comments Download
D recipes/fletch.py View 1 chunk +0 lines, -45 lines 0 comments Download
D recipes/gyp.py View 1 chunk +0 lines, -42 lines 0 comments Download
D recipes/infra.py View 1 chunk +0 lines, -41 lines 0 comments Download
D recipes/infra_internal.py View 1 chunk +0 lines, -46 lines 0 comments Download
D recipes/ios.py View 1 chunk +0 lines, -34 lines 0 comments Download
D recipes/mojo.py View 1 chunk +0 lines, -46 lines 0 comments Download
D recipes/nacl.py View 1 chunk +0 lines, -49 lines 0 comments Download
D recipes/naclports.py View 1 chunk +0 lines, -48 lines 0 comments Download
D recipes/pdfium.py View 1 chunk +0 lines, -40 lines 0 comments Download
D recipes/recipe_util.py View 1 chunk +0 lines, -50 lines 0 comments Download
D recipes/skia.py View 1 chunk +0 lines, -41 lines 0 comments Download
D recipes/skia_buildbot.py View 1 chunk +0 lines, -41 lines 0 comments Download
D recipes/v8.py View 1 chunk +0 lines, -45 lines 0 comments Download
D recipes/webrtc.py View 1 chunk +0 lines, -50 lines 0 comments Download
D recipes/webrtc_android.py View 1 chunk +0 lines, -34 lines 0 comments Download
D recipes/webrtc_ios.py View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
luqui
ptal
5 years ago (2015-12-02 22:52:47 UTC) #2
iannucci
On 2015/12/02 at 22:52:47, luqui wrote: > ptal could we rename them to fetch_configs while ...
5 years ago (2015-12-02 22:56:45 UTC) #4
Dirk Pranke
On 2015/12/02 22:56:45, iannucci wrote: > On 2015/12/02 at 22:52:47, luqui wrote: > > ptal ...
5 years ago (2015-12-02 23:10:50 UTC) #5
agable
Yep, 100% with iannucci and dpranke on this. When these were first created, they were ...
5 years ago (2015-12-03 00:46:14 UTC) #6
luqui
done ptal
5 years ago (2015-12-03 02:38:58 UTC) #7
iannucci
lgtm
5 years ago (2015-12-03 04:21:35 UTC) #10
Dirk Pranke
lgtm
5 years ago (2015-12-04 00:15:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494793002/20001
5 years ago (2015-12-04 00:37:47 UTC) #13
luqui
5 years ago (2015-12-04 01:42:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 297837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698