Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1490113005: Add config options to run different GPU APIs to dm and nanobench (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
4 years, 12 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-03-context-factory-glcontext-type
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add config options to run different GPU APIs to dm and nanobench Add extended config specification form that can be used to run different gpu backend with different APIs. The configs can be specified with the form: gpu(api=string,dit=bool,nvpr=bool,samples=int) This replaces and removes the --gpuAPI flag. All existing configs should still work. Adds following documentation: out/Debug/dm --help config Flags: --config: type: string default: 565 8888 gpu nonrendering Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4 nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg xps or use extended form 'backend(option=value,...)'. Extended form: 'backend(option=value,...)' Possible backends and options: gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend api type: string default: native. Select graphics API to use with gpu backend. Options: native Use platform default OpenGL or OpenGL ES backend. gl Use OpenGL. gles Use OpenGL ES. debug Use debug OpenGL. null Use null OpenGL. dit type: bool default: false. Use device independent text. nvpr type: bool default: false. Use NV_path_rendering OpenGL and OpenGL ES extension. samples type: int default: 0. Use multisampling with N samples. Predefined configs: gpu = gpu() msaa4 = gpu(samples=4) msaa16 = gpu(samples=16) nvprmsaa4 = gpu(nvpr=true,samples=4) nvprmsaa16 = gpu(nvpr=true,samples=16) gpudft = gpu(dit=true) gpudebug = gpu(api=debug) gpunull = gpu(api=null) debug = gpu(api=debug) nullgpu = gpu(api=null) BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/e13ca329fca4c28cf4e078561f591ab27b743d23 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1490113005 Committed: https://skia.googlesource.com/skia/+/c8b4336444e7b90382e04e33665fb3b8490b825b Committed: https://skia.googlesource.com/skia/+/9ebc3f0ee6db215dde461dc4777d85988cf272dd Committed: https://skia.googlesource.com/skia/+/3e980c3d88fbc509b79e7ccef16ca38f5bbfb180

Patch Set 1 #

Total comments: 5

Patch Set 2 : win angle #

Total comments: 36

Patch Set 3 : address review comments #

Patch Set 4 : address review comments #

Patch Set 5 : fix errorneous config handling #

Total comments: 10

Patch Set 6 : add a missing hunk #

Patch Set 7 : address review comments #

Patch Set 8 : win fixes #

Patch Set 9 : rebase #

Patch Set 10 : fix clang compile errors #

Patch Set 11 : msvc fixes #

Patch Set 12 : msvc x86_64 fixes #

Patch Set 13 : fix chromium build #

Total comments: 1

Patch Set 14 : address review comment #

Patch Set 15 : #

Patch Set 16 : #

Total comments: 3

Patch Set 17 : rebase for merge #

Patch Set 18 : unused param warnding #

Patch Set 19 : make tag be always the full --config word #

Patch Set 20 : rebase #

Patch Set 21 : #

Patch Set 22 : remove context iteration from GLProgramsTest #

Patch Set 23 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1112 lines, -240 lines) Patch
M bench/nanobench.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +8 lines, -6 lines 0 comments Download
M dm/DM.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 15 chunks +87 lines, -82 lines 0 comments Download
M dm/DMGpuSupport.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M dm/DMSrcSink.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -4 lines 0 comments Download
M gyp/flags.gyp View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M include/core/SkString.h View 1 2 3 4 5 6 1 chunk +16 lines, -1 line 0 comments Download
M include/gpu/gl/SkNullGLContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +6 lines, -1 line 0 comments Download
M include/gpu/gl/angle/SkANGLEGLContext.h View 1 2 1 chunk +11 lines, -4 lines 0 comments Download
M include/gpu/gl/command_buffer/SkCommandBufferGLContext.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkString.cpp View 1 2 3 4 5 6 1 chunk +26 lines, -7 lines 0 comments Download
M src/gpu/GrContextFactory.h View 1 2 3 4 5 6 7 8 9 4 chunks +22 lines, -13 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 1 2 2 chunks +19 lines, -14 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 2 3 4 5 6 7 1 chunk +6 lines, -1 line 0 comments Download
M src/gpu/gl/debug/SkDebugGLContext.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/gl/mesa/SkMesaGLContext.h View 1 chunk +1 line, -4 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +43 lines, -37 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M tests/StringTest.cpp View 1 2 3 4 5 6 1 chunk +54 lines, -1 line 0 comments Download
A tests/TestConfigParsing.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +314 lines, -0 lines 0 comments Download
M tools/flags/SkCommandLineFlags.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 11 chunks +30 lines, -8 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +36 lines, -23 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
A tools/flags/SkCommonFlagsConfig.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +74 lines, -0 lines 0 comments Download
A tools/flags/SkCommonFlagsConfig.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +336 lines, -0 lines 0 comments Download

Messages

Total messages: 106 (38 generated)
Kimmo Kinnunen
So here's an option how the command buffer can be selected with NVPR. Feel free ...
5 years ago (2015-12-02 14:11:29 UTC) #2
bsalomon
I like this direction a lot. The current set of predefined configs is too rigid. ...
5 years ago (2015-12-02 23:22:42 UTC) #4
joshualitt
On 2015/12/02 23:22:42, bsalomon wrote: > I like this direction a lot. The current set ...
5 years ago (2015-12-03 16:11:06 UTC) #5
scroggo
https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommandLineFlags.cpp File tools/flags/SkCommandLineFlags.cpp (right): https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommandLineFlags.cpp#newcode27 tools/flags/SkCommandLineFlags.cpp:27: SkFlagInfo* info = new SkFlagInfo(name, shortName, kString_FlagType, helpString, extendedHelpString); ...
5 years ago (2015-12-03 19:02:59 UTC) #6
Kimmo Kinnunen
Sorry for the line ends. I try to configure emacs, yet again. https://codereview.chromium.org/1490113005/diff/1/dm/DM.cpp File dm/DM.cpp ...
5 years ago (2015-12-04 14:26:19 UTC) #7
scroggo
1gtm for the flags changes https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommandLineFlags.h File tools/flags/SkCommandLineFlags.h (right): https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommandLineFlags.h#newcode434 tools/flags/SkCommandLineFlags.h:434: SkFlagInfo(const char* name, const ...
5 years ago (2015-12-04 16:40:03 UTC) #8
Kimmo Kinnunen
https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommandLineFlags.h File tools/flags/SkCommandLineFlags.h (right): https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommandLineFlags.h#newcode434 tools/flags/SkCommandLineFlags.h:434: SkFlagInfo(const char* name, const char* shortName, FlagTypes type, const ...
5 years ago (2015-12-07 09:26:48 UTC) #9
scroggo
https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommonFlagsConfig.cpp File tools/flags/SkCommonFlagsConfig.cpp (right): https://codereview.chromium.org/1490113005/diff/20001/tools/flags/SkCommonFlagsConfig.cpp#newcode227 tools/flags/SkCommonFlagsConfig.cpp:227: if (options.endsWith(",") || options.startsWith(",")) { On 2015/12/07 09:26:48, Kimmo ...
5 years ago (2015-12-07 13:27:52 UTC) #10
bsalomon
https://codereview.chromium.org/1490113005/diff/1/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/1490113005/diff/1/dm/DM.cpp#newcode615 dm/DM.cpp:615: contextType = GrContextFactory::kANGLE_GL_GLContextType; On 2015/12/04 14:26:18, Kimmo Kinnunen wrote: ...
5 years ago (2015-12-07 14:33:19 UTC) #11
Kimmo Kinnunen
https://codereview.chromium.org/1490113005/diff/80001/include/core/SkString.h File include/core/SkString.h (right): https://codereview.chromium.org/1490113005/diff/80001/include/core/SkString.h#newcode270 include/core/SkString.h:270: enum SkStrSplitResult { On 2015/12/07 13:27:52, scroggo wrote: > ...
5 years ago (2015-12-08 09:07:51 UTC) #12
Kimmo Kinnunen
On 2015/12/07 14:33:19, bsalomon wrote: > https://codereview.chromium.org/1490113005/diff/1/dm/DM.cpp > File dm/DM.cpp (right): > > https://codereview.chromium.org/1490113005/diff/1/dm/DM.cpp#newcode615 > ...
5 years ago (2015-12-08 09:31:43 UTC) #14
bsalomon
On 2015/12/08 09:31:43, Kimmo Kinnunen wrote: > On 2015/12/07 14:33:19, bsalomon wrote: > > https://codereview.chromium.org/1490113005/diff/1/dm/DM.cpp ...
5 years ago (2015-12-08 15:05:26 UTC) #15
scroggo
On 2015/12/08 15:05:26, bsalomon wrote: > On 2015/12/08 09:31:43, Kimmo Kinnunen wrote: > > On ...
5 years ago (2015-12-08 20:06:49 UTC) #16
bsalomon
On 2015/12/08 20:06:49, scroggo wrote: > On 2015/12/08 15:05:26, bsalomon wrote: > > On 2015/12/08 ...
5 years ago (2015-12-08 20:14:06 UTC) #17
scroggo
On 2015/12/08 20:14:06, bsalomon wrote: > On 2015/12/08 20:06:49, scroggo wrote: > > On 2015/12/08 ...
5 years ago (2015-12-08 21:33:44 UTC) #18
Kimmo Kinnunen
On 2015/12/08 21:33:44, scroggo wrote: > On 2015/12/08 20:14:06, bsalomon wrote: > > The only ...
5 years ago (2015-12-09 07:18:06 UTC) #19
Kimmo Kinnunen
On 2015/12/09 07:18:06, Kimmo Kinnunen wrote: > On 2015/12/08 21:33:44, scroggo wrote: > > On ...
5 years ago (2015-12-09 15:51:17 UTC) #20
scroggo
On 2015/12/09 15:51:17, Kimmo Kinnunen wrote: > On 2015/12/09 07:18:06, Kimmo Kinnunen wrote: > > ...
5 years ago (2015-12-09 16:31:18 UTC) #21
bsalomon
On 2015/12/09 16:31:18, scroggo wrote: > On 2015/12/09 15:51:17, Kimmo Kinnunen wrote: > > On ...
5 years ago (2015-12-09 17:14:58 UTC) #22
scroggo
On 2015/12/09 17:14:58, bsalomon wrote: > On 2015/12/09 16:31:18, scroggo wrote: > > On 2015/12/09 ...
5 years ago (2015-12-09 18:23:28 UTC) #23
Kimmo Kinnunen
On 2015/12/09 18:23:28, scroggo wrote: > On 2015/12/09 17:14:58, bsalomon wrote: > > Leon, if ...
5 years ago (2015-12-11 07:52:34 UTC) #24
bsalomon
On 2015/12/11 07:52:34, Kimmo Kinnunen wrote: > On 2015/12/09 18:23:28, scroggo wrote: > > On ...
5 years ago (2015-12-11 13:59:55 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/160001
5 years ago (2015-12-14 08:06:57 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4806)
5 years ago (2015-12-14 08:07:56 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/180001
5 years ago (2015-12-14 08:32:13 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4802) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years ago (2015-12-14 08:34:48 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/200001
5 years ago (2015-12-14 09:35:34 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4863)
5 years ago (2015-12-14 09:37:57 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/220001
5 years ago (2015-12-14 12:34:18 UTC) #43
commit-bot: I haz the power
Committed patchset #12 (id:220001) as https://skia.googlesource.com/skia/+/e13ca329fca4c28cf4e078561f591ab27b743d23
5 years ago (2015-12-14 12:49:21 UTC) #45
reed1
A revert of this CL (patchset #12 id:220001) has been created in https://codereview.chromium.org/1528473002/ by reed@google.com. ...
5 years ago (2015-12-14 13:58:03 UTC) #46
jcgregorio
On 2015/12/14 at 13:58:03, reed wrote: > A revert of this CL (patchset #12 id:220001) ...
5 years ago (2015-12-14 17:01:23 UTC) #47
jcgregorio
On 2015/12/14 at 17:01:23, jcgregorio wrote: > On 2015/12/14 at 13:58:03, reed wrote: > > ...
5 years ago (2015-12-14 17:02:28 UTC) #48
Kimmo Kinnunen
On 2015/12/14 17:02:28, jcgregorio wrote: > On 2015/12/14 at 17:01:23, jcgregorio wrote: > > On ...
5 years ago (2015-12-15 11:52:53 UTC) #50
bsalomon
Looking at the graphs now, the rises and falls don't appear related to this change. ...
5 years ago (2015-12-15 19:55:12 UTC) #51
mtklein
https://codereview.chromium.org/1490113005/diff/240001/tests/TestConfigParsing.cpp File tests/TestConfigParsing.cpp (right): https://codereview.chromium.org/1490113005/diff/240001/tests/TestConfigParsing.cpp#newcode7 tests/TestConfigParsing.cpp:7: Before you reland this, please make sure these new ...
5 years ago (2015-12-15 23:47:39 UTC) #53
Kimmo Kinnunen
On 2015/12/15 23:47:39, mtklein wrote: > https://codereview.chromium.org/1490113005/diff/240001/tests/TestConfigParsing.cpp > File tests/TestConfigParsing.cpp (right): > > https://codereview.chromium.org/1490113005/diff/240001/tests/TestConfigParsing.cpp#newcode7 > ...
5 years ago (2015-12-16 07:02:03 UTC) #54
mtklein
On 2015/12/16 at 07:02:03, kkinnunen wrote: > On 2015/12/15 23:47:39, mtklein wrote: > > https://codereview.chromium.org/1490113005/diff/240001/tests/TestConfigParsing.cpp ...
5 years ago (2015-12-16 13:29:28 UTC) #55
mtklein
https://codereview.chromium.org/1490113005/diff/300001/tools/flags/SkCommonFlagsConfig.h File tools/flags/SkCommonFlagsConfig.h (right): https://codereview.chromium.org/1490113005/diff/300001/tools/flags/SkCommonFlagsConfig.h#newcode26 tools/flags/SkCommonFlagsConfig.h:26: // where 'tag' consists of chars excluding hyphen or ...
5 years ago (2015-12-16 13:31:11 UTC) #56
Kimmo Kinnunen
https://codereview.chromium.org/1490113005/diff/300001/tools/flags/SkCommandLineFlags.h File tools/flags/SkCommandLineFlags.h (right): https://codereview.chromium.org/1490113005/diff/300001/tools/flags/SkCommandLineFlags.h#newcode122 tools/flags/SkCommandLineFlags.h:122: StringArray() { } Mike, I meant this addition. This ...
5 years ago (2015-12-17 05:57:54 UTC) #57
mtklein
https://codereview.chromium.org/1490113005/diff/300001/tools/flags/SkCommandLineFlags.h File tools/flags/SkCommandLineFlags.h (right): https://codereview.chromium.org/1490113005/diff/300001/tools/flags/SkCommandLineFlags.h#newcode122 tools/flags/SkCommandLineFlags.h:122: StringArray() { } On 2015/12/17 at 05:57:53, Kimmo Kinnunen ...
5 years ago (2015-12-17 14:50:50 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/320001
5 years ago (2015-12-18 10:55:53 UTC) #62
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/4921)
5 years ago (2015-12-18 10:57:01 UTC) #64
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/340001
5 years ago (2015-12-18 11:12:43 UTC) #67
commit-bot: I haz the power
Committed patchset #18 (id:340001) as https://skia.googlesource.com/skia/+/c8b4336444e7b90382e04e33665fb3b8490b825b
5 years ago (2015-12-18 11:27:37 UTC) #69
Kimmo Kinnunen
On 2015/12/18 11:27:37, commit-bot: I haz the power wrote: > Committed patchset #18 (id:340001) as ...
5 years ago (2015-12-18 13:19:12 UTC) #70
joshualitt
A revert of this CL (patchset #18 id:340001) has been created in https://codereview.chromium.org/1536963002/ by joshualitt@google.com. ...
5 years ago (2015-12-18 14:01:49 UTC) #71
fmalita_google_do_not_use
On 2015/12/18 14:01:49, joshualitt wrote: > A revert of this CL (patchset #18 id:340001) has ...
5 years ago (2015-12-18 14:07:32 UTC) #72
joshualitt
On 2015/12/18 14:07:32, fmalita_google_do_not_use wrote: > On 2015/12/18 14:01:49, joshualitt wrote: > > A revert ...
5 years ago (2015-12-18 14:25:38 UTC) #74
bsalomon
On 2015/12/18 14:07:32, fmalita_google_do_not_use wrote: > On 2015/12/18 14:01:49, joshualitt wrote: > > A revert ...
5 years ago (2015-12-18 14:27:15 UTC) #75
Kimmo Kinnunen
Thanks, I will try the trybots. Sorry for the trouble..
5 years ago (2015-12-18 14:31:35 UTC) #76
joshualitt
On 2015/12/18 14:31:35, Kimmo Kinnunen wrote: > Thanks, I will try the trybots. Sorry for ...
5 years ago (2015-12-18 14:34:14 UTC) #77
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/380001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/380001
5 years ago (2015-12-21 11:13:42 UTC) #79
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/4890)
5 years ago (2015-12-21 11:17:22 UTC) #81
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/400001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/400001
5 years ago (2015-12-21 12:04:53 UTC) #83
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-21 12:19:47 UTC) #85
Kimmo Kinnunen
So if I understand correctly: after that dry run, I should see Gold results from ...
5 years ago (2015-12-21 13:50:13 UTC) #86
mtklein
On 2015/12/21 at 13:50:13, kkinnunen wrote: > So if I understand correctly: after that dry ...
5 years ago (2015-12-21 14:12:30 UTC) #87
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/400001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/400001
5 years ago (2015-12-22 07:47:18 UTC) #90
commit-bot: I haz the power
Committed patchset #21 (id:400001) as https://skia.googlesource.com/skia/+/9ebc3f0ee6db215dde461dc4777d85988cf272dd
5 years ago (2015-12-22 07:48:19 UTC) #92
rmistry
On 2015/12/22 07:48:19, commit-bot: I haz the power wrote: > Committed patchset #21 (id:400001) as ...
5 years ago (2015-12-22 15:50:54 UTC) #93
rmistry
A revert of this CL (patchset #21 id:400001) has been created in https://codereview.chromium.org/1548683002/ by rmistry@google.com. ...
5 years ago (2015-12-22 18:22:09 UTC) #94
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/440001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/440001
5 years ago (2015-12-23 09:05:58 UTC) #97
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-23 09:23:07 UTC) #99
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113005/440001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113005/440001
5 years ago (2015-12-23 09:30:32 UTC) #102
commit-bot: I haz the power
Committed patchset #23 (id:440001) as https://skia.googlesource.com/skia/+/3e980c3d88fbc509b79e7ccef16ca38f5bbfb180
5 years ago (2015-12-23 09:33:06 UTC) #104
mtklein
On 2015/12/23 09:33:06, commit-bot: I haz the power wrote: > Committed patchset #23 (id:440001) as ...
4 years, 12 months ago (2015-12-28 18:00:13 UTC) #105
Kimmo Kinnunen
4 years, 12 months ago (2015-12-29 08:42:26 UTC) #106
Message was sent while issue was closed.
On 2015/12/28 18:00:13, mtklein wrote:
> On 2015/12/23 09:33:06, commit-bot: I haz the power wrote:
> > Committed patchset #23 (id:440001) as
> >
https://skia.googlesource.com/skia/+/3e980c3d88fbc509b79e7ccef16ca38f5bbfb180
> 
> Looks like there are still some new images when using NVPR on the Tegra K1:
>
https://gold.skia.org/search2?blame=9ebc3f0ee6db215dde461dc4777d85988cf272dd&...
> 
> While most of those diffs are pretty small, textblobmixedsizes is very
> noticeably changed along the upper edge of the lower half of the S.  Is that
> expected?

Thanks for the inspection. I wasn't aware of DM running with device-independent
text.
Fixed here:
https://codereview.chromium.org/1553453004/

Powered by Google App Engine
This is Rietveld 408576698