|
|
[RFP, Autofill] Switching dialog field identification to int.
Upside:
* It's clearer to see if we care about a field type or a field in
a specifc section. (Because the latter requires a section spec)
* It'll be easier to have section-specific calls on a section object.
* Both Views and Cocoa will be able to look up fields via their tagging
system - less code. (We _could_ tag with addresses, but it turns
into a nasty-cast fest without much pointer validation)
Downside:
* It's a big-ish change.
BUG=none
Closed, because it went nowhere - but gave a lot of insight into the code
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+152 lines, -148 lines) |
Patch |
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
|
View
|
|
2 chunks |
+19 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
|
View
|
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
|
View
|
|
14 chunks |
+42 lines, -47 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
|
View
|
|
5 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_types.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/autofill_dialog_view.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/mock_autofill_dialog_controller.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/mock_autofill_dialog_controller.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/autofill/testable_autofill_dialog_view.h
|
View
|
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/autofill/autofill_dialog_views.h
|
View
|
|
4 chunks |
+17 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/autofill/autofill_dialog_views.cc
|
View
|
|
12 chunks |
+45 lines, -48 lines |
0 comments
|
Download
|
|