[RFP, Autofill] Switching dialog field identification to int.

chrome/browser/ui/views/autofill/autofill_dialog_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_
 
 #include <map>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 63 matching lines @@
   virtual ~AutofillDialogViews();
 
   // AutofillDialogView implementation:
   virtual void Show() OVERRIDE;
   virtual void Hide() OVERRIDE;
   virtual void UpdateAccountChooser() OVERRIDE;
   virtual void UpdateButtonStrip() OVERRIDE;
   virtual void UpdateNotificationArea() OVERRIDE;
   virtual void UpdateSection(DialogSection section) OVERRIDE;
   virtual void FillSection(DialogSection section,
-                           const DetailInput& originating_input) OVERRIDE;
-  virtual void GetUserInput(DialogSection section,
-                            DetailOutputMap* output) OVERRIDE;
+                           AutofillFieldType originating_input) OVERRIDE;
+  virtual void GetUserInput(DialogSection section, DetailOutputMap* output)
+      OVERRIDE;
   virtual string16 GetCvc() OVERRIDE;
   virtual bool SaveDetailsLocally() OVERRIDE;
   virtual const content::NavigationController* ShowSignIn() OVERRIDE;
   virtual void HideSignIn() OVERRIDE;
   virtual void UpdateProgressBar(double value) OVERRIDE;
   virtual void ModelChanged() OVERRIDE;
   virtual TestableAutofillDialogView* GetTestableView() OVERRIDE;
 
   // TestableAutofillDialogView implementation:
   virtual void SubmitForTesting() OVERRIDE;
   virtual void CancelForTesting() OVERRIDE;
-  virtual string16 GetTextContentsOfInput(const DetailInput& input) OVERRIDE;
-  virtual void SetTextContentsOfInput(const DetailInput& input,
+  virtual string16 GetTextContentsOfInput(DialogSection section,
+                                          AutofillFieldType type) OVERRIDE;
+  virtual void SetTextContentsOfInput(DialogSection section,
+                                      AutofillFieldType type,
                                       const string16& contents) OVERRIDE;
-  virtual void ActivateInput(const DetailInput& input) OVERRIDE;
+  virtual void ActivateInput(DialogSection section, AutofillFieldType type)
+      OVERRIDE;
 
   // views::DialogDelegate implementation:
   virtual string16 GetWindowTitle() const OVERRIDE;
   virtual void WindowClosing() OVERRIDE;
   virtual void DeleteDelegate() OVERRIDE;
   virtual views::Widget* GetWidget() OVERRIDE;
   virtual const views::Widget* GetWidget() const OVERRIDE;
   virtual views::View* GetContentsView() OVERRIDE;
   virtual int GetDialogButtons() const OVERRIDE;
   virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
@@ skipping 168 matching lines @@
     views::Checkbox* checkbox_;  // weak
 
     // If HasArrow() is true, the arrow should point at this.
     base::WeakPtr<views::View> arrow_centering_anchor_;
 
     std::vector<DialogNotification> notifications_;
 
     DISALLOW_COPY_AND_ASSIGN(NotificationArea);
   };
 
-  typedef std::map<const DetailInput*, DecoratedTextfield*> TextfieldMap;
-  typedef std::map<const DetailInput*, views::Combobox*> ComboboxMap;
+  typedef std::map<AutofillFieldType, DecoratedTextfield*> TextfieldMap;
+  typedef std::map<AutofillFieldType, views::Combobox*> ComboboxMap;
 
   // A view that packs a label on the left and some related controls
   // on the right.
   class SectionContainer : public views::View {
    public:
     SectionContainer(const string16& label,
                      views::View* controls,
                      views::Button* proxy_button);
     virtual ~SectionContainer();
 
@@ skipping 159 matching lines @@
 
   // When an input textfield is edited (its contents change) or activated
   // (clicked while focused), this function will inform the controller that it's
   // time to show a suggestion popup and possibly reset the validity state of
   // the input.
   void TextfieldEditedOrActivated(views::Textfield* textfield, bool was_edit);
 
   // Call this when the size of anything in |contents_| might've changed.
   void ContentsPreferredSizeChanged();
 
-  // Gets the textfield view that is shown for the given DetailInput model, or
+  // Gets the textfield view that is identified by |section| and |type|, or
   // NULL.
-  views::Textfield* TextfieldForInput(const DetailInput& input);
+  views::Textfield* TextfieldForInput(DialogSection section,
+                                      AutofillFieldType type);
 
-  // Gets the combobox view that is shown for the given DetailInput model, or
+  // Gets the combobox view that is identified by |section| and |type|, or
   // NULL.
-  views::Combobox* ComboboxForInput(const DetailInput& input);
+  views::Combobox* ComboboxForInput(DialogSection section,
+                                    AutofillFieldType type);
 
   // The controller that drives this view. Weak pointer, always non-NULL.
   AutofillDialogController* const controller_;
 
   // The window that displays |contents_|. Weak pointer; may be NULL when the
   // dialog is closing.
   views::Widget* window_;
 
   // The top-level View for the dialog. Owned by the constrained window.
   views::View* contents_;
@@ skipping 54 matching lines @@
   views::FocusManager* focus_manager_;
 
   ScopedObserver<views::Widget, AutofillDialogViews> observer_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogViews);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_DIALOG_VIEWS_H_