[RFP, Autofill] Switching dialog field identification to int.

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
@@ skipping 36 matching lines @@
   TestAutofillDialogView() {}
   virtual ~TestAutofillDialogView() {}
 
   virtual void Show() OVERRIDE {}
   virtual void Hide() OVERRIDE {}
   virtual void UpdateNotificationArea() OVERRIDE {}
   virtual void UpdateAccountChooser() OVERRIDE {}
   virtual void UpdateButtonStrip() OVERRIDE {}
   virtual void UpdateSection(DialogSection section) OVERRIDE {}
   virtual void FillSection(DialogSection section,
-                           const DetailInput& originating_input) OVERRIDE {};
+                           AutofillFieldType originating_input) OVERRIDE {}
   virtual void GetUserInput(DialogSection section, DetailOutputMap* output)
       OVERRIDE {
     *output = outputs_[section];
   }
 
   virtual string16 GetCvc() OVERRIDE { return string16(); }
   virtual bool SaveDetailsLocally() OVERRIDE { return true; }
   virtual const content::NavigationController* ShowSignIn() OVERRIDE {
     return NULL;
   }
@@ skipping 194 matching lines @@
     list->AppendString("verify_cvv");
     dict.Set("required_action", list.release());
     return wallet::FullWallet::CreateFullWallet(dict);
   }
 
   void FillCreditCardInputs() {
     DetailOutputMap cc_outputs;
     const DetailInputs& cc_inputs =
         controller()->RequestedFieldsForSection(SECTION_CC);
     for (size_t i = 0; i < cc_inputs.size(); ++i) {
-      cc_outputs[&cc_inputs[i]] = ASCIIToUTF16("11");
+      cc_outputs[cc_inputs[i].type] = ASCIIToUTF16("11");
     }
     controller()->GetView()->SetUserInput(SECTION_CC, cc_outputs);
   }
 
   std::vector<DialogNotification> NotificationsOfType(
       DialogNotification::Type type) {
     std::vector<DialogNotification> right_type;
     const std::vector<DialogNotification>& notifications =
         controller()->CurrentNotifications();
     for (size_t i = 0; i < notifications.size(); ++i) {
@@ skipping 241 matching lines @@
 
   AutofillProfile full_profile(test::GetFullProfile());
   controller()->GetTestingManager()->AddTestingProfile(&full_profile);
   controller()->EditClickedForSection(SECTION_SHIPPING);
 
   DetailOutputMap outputs;
   const DetailInputs& inputs =
       controller()->RequestedFieldsForSection(SECTION_SHIPPING);
   for (size_t i = 0; i < inputs.size(); ++i) {
     const DetailInput& input = inputs[i];
-    outputs[&input] = input.type == NAME_FULL ? ASCIIToUTF16("Edited Name") :
-                                                input.initial_value;
+    outputs[input.type] = input.type == NAME_FULL ? ASCIIToUTF16("Edited Name")
+                                                  : input.initial_value;
   }
   controller()->GetView()->SetUserInput(SECTION_SHIPPING, outputs);
 
   // We also have to simulate CC inputs to keep the controller happy.
   FillCreditCardInputs();
 
   controller()->OnAccept();
   const AutofillProfile& edited_profile =
       controller()->GetTestingManager()->imported_profile();
 
@@ skipping 16 matching lines @@
   // Activate the "Add billing address" menu item.
   model->ActivatedAt(model->GetItemCount() - 2);
 
   // Fill in the inputs from the profile.
   DetailOutputMap outputs;
   const DetailInputs& inputs =
       controller()->RequestedFieldsForSection(SECTION_BILLING);
   AutofillProfile full_profile2(test::GetFullProfile2());
   for (size_t i = 0; i < inputs.size(); ++i) {
     const DetailInput& input = inputs[i];
-    outputs[&input] = full_profile2.GetInfo(input.type, "en-US");
+    outputs[input.type] = full_profile2.GetInfo(input.type, "en-US");
   }
   controller()->GetView()->SetUserInput(SECTION_BILLING, outputs);
 
   // Fill in some CC info. The name field will be used to fill in the billing
   // address name in the newly minted AutofillProfile.
   DetailOutputMap cc_outputs;
   const DetailInputs& cc_inputs =
       controller()->RequestedFieldsForSection(SECTION_CC);
   for (size_t i = 0; i < cc_inputs.size(); ++i) {
-    cc_outputs[&cc_inputs[i]] = cc_inputs[i].type == CREDIT_CARD_NAME ?
-        ASCIIToUTF16("Bill Money") : ASCIIToUTF16("111");
+    cc_outputs[cc_inputs[i].type] =
+        cc_inputs[i].type == CREDIT_CARD_NAME ? ASCIIToUTF16("Bill Money")
+                                              : ASCIIToUTF16("111");
   }
   controller()->GetView()->SetUserInput(SECTION_CC, cc_outputs);
 
   controller()->OnAccept();
   const AutofillProfile& added_profile =
       controller()->GetTestingManager()->imported_profile();
 
   const DetailInputs& shipping_inputs =
       controller()->RequestedFieldsForSection(SECTION_SHIPPING);
   for (size_t i = 0; i < shipping_inputs.size(); ++i) {
@@ skipping 315 matching lines @@
   EXPECT_FALSE(controller()->ShouldOfferToSaveInChrome());
 
   controller()->MenuModelForSection(SECTION_EMAIL)->ActivatedAt(1);
   EXPECT_TRUE(controller()->ShouldOfferToSaveInChrome());
 
   profile()->set_incognito(true);
   EXPECT_FALSE(controller()->ShouldOfferToSaveInChrome());
 }
 
 }  // namespace autofill