[RFP, Autofill] Switching dialog field identification to int.

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
@@ skipping 93 matching lines @@
   }
 
   virtual std::vector<AutofillFieldType> InputsAreValid(
       const DetailOutputMap& inputs,
       ValidationType validation_type) const OVERRIDE {
     return std::vector<AutofillFieldType>();
   }
 
   // Increase visibility for testing.
   AutofillDialogView* view() { return AutofillDialogControllerImpl::view(); }
-  const DetailInput* input_showing_popup() const {
-    return AutofillDialogControllerImpl::input_showing_popup();
+  const AutofillFieldType input_showing_popup_type() const {
+    return AutofillDialogControllerImpl::input_showing_popup_type();
   }
 
   TestPersonalDataManager* GetTestingManager() {
     return &test_manager_;
   }
 
  protected:
   virtual PersonalDataManager* GetManager() OVERRIDE {
     return &test_manager_;
   }
@@ skipping 132 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest, FillInputFromAutofill) {
   InitializeControllerOfType(DIALOG_TYPE_REQUEST_AUTOCOMPLETE);
 
   AutofillProfile full_profile(test::GetFullProfile());
   controller()->GetTestingManager()->AddTestingProfile(&full_profile);
 
   const DetailInputs& inputs =
       controller()->RequestedFieldsForSection(SECTION_SHIPPING);
-  const DetailInput& triggering_input = inputs[0];
-  string16 value = full_profile.GetRawInfo(triggering_input.type);
+  AutofillFieldType triggering_input = inputs[0].type;
+  string16 value = full_profile.GetRawInfo(triggering_input);
   TestableAutofillDialogView* view = controller()->view()->GetTestableView();
-  view->SetTextContentsOfInput(triggering_input,
-                               value.substr(0, value.size() / 2));
-  view->ActivateInput(triggering_input);
+  view->SetTextContentsOfInput(
+      SECTION_SHIPPING, triggering_input, value.substr(0, value.size() / 2));
+  view->ActivateInput(SECTION_SHIPPING, triggering_input);
 
-  ASSERT_EQ(&triggering_input, controller()->input_showing_popup());
+  ASSERT_EQ(triggering_input, controller()->input_showing_popup_type());
   controller()->DidAcceptSuggestion(string16(), 0);
 
   // All inputs should be filled.
   AutofillProfileWrapper wrapper(&full_profile, 0);
   for (size_t i = 0; i < inputs.size(); ++i) {
     EXPECT_EQ(wrapper.GetInfo(inputs[i].type),
-              view->GetTextContentsOfInput(inputs[i]));
+              view->GetTextContentsOfInput(SECTION_SHIPPING, inputs[i].type));
   }
 
   // Now simulate some user edits and try again.
   std::vector<string16> expectations;
   for (size_t i = 0; i < inputs.size(); ++i) {
     string16 users_input = i % 2 == 0 ? string16() : ASCIIToUTF16("dummy");
-    view->SetTextContentsOfInput(inputs[i], users_input);
+    view->SetTextContentsOfInput(SECTION_SHIPPING, inputs[i].type, users_input);
     // Empty inputs should be filled, others should be left alone.
     string16 expectation =
-        &inputs[i] == &triggering_input || users_input.empty() ?
-        wrapper.GetInfo(inputs[i].type) :
-        users_input;
+        inputs[i].type == triggering_input || users_input.empty()
+            ? wrapper.GetInfo(inputs[i].type)
+            : users_input;
     expectations.push_back(expectation);
   }
 
-  view->SetTextContentsOfInput(triggering_input,
-                               value.substr(0, value.size() / 2));
-  view->ActivateInput(triggering_input);
-  ASSERT_EQ(&triggering_input, controller()->input_showing_popup());
+  view->SetTextContentsOfInput(
+      SECTION_SHIPPING, triggering_input, value.substr(0, value.size() / 2));
+  view->ActivateInput(SECTION_SHIPPING, triggering_input);
+  ASSERT_EQ(triggering_input, controller()->input_showing_popup_type());
   controller()->DidAcceptSuggestion(string16(), 0);
 
   for (size_t i = 0; i < inputs.size(); ++i) {
-    EXPECT_EQ(expectations[i], view->GetTextContentsOfInput(inputs[i]));
+    EXPECT_EQ(expectations[i],
+              view->GetTextContentsOfInput(SECTION_SHIPPING, inputs[i].type));
   }
 }
 #endif  // defined(TOOLKIT_VIEWS)
 
 }  // namespace autofill