Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4212)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 14821005: [RFP, Autofill] Switching dialog field identification to int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index 0394d0f730607e4aad128f1c54256b08faba2b68..9a9fc610a15d99389b438a5f90bb08aa892e0ea6 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -129,7 +129,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
virtual std::vector<AutofillFieldType> InputsAreValid(
const DetailOutputMap& inputs,
ValidationType validation_type) const OVERRIDE;
- virtual void UserEditedOrActivatedInput(const DetailInput* input,
+ virtual void UserEditedOrActivatedInput(DialogSection section,
+ AutofillFieldType type,
gfx::NativeView parent_view,
const gfx::Rect& content_bounds,
const string16& field_contents,
@@ -232,8 +233,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// Exposed for testing.
AutofillDialogView* view() { return view_.get(); }
virtual AutofillDialogView* CreateView();
- const DetailInput* input_showing_popup() const {
- return input_showing_popup_;
+ AutofillFieldType input_showing_popup_type() const {
+ return input_showing_popup_type_;
}
// Returns the PersonalDataManager for |profile_|.
@@ -522,7 +523,7 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// The input for which |popup_controller_| is currently showing a popup
// (if any).
- const DetailInput* input_showing_popup_;
+ AutofillFieldType input_showing_popup_type_;
scoped_ptr<AutofillDialogView> view_;

Powered by Google App Engine
This is Rietveld 408576698