Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1481613002: Create ast/ and parsing/ subdirectories and move appropriate files (Closed)

Created:
5 years ago by rossberg
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Create ast/ and parsing/ subdirectories and move appropriate files Moves all files related to AST and scopes into ast/, and all files related to scanner & parser to parsing/. Also eliminates a couple of spurious dependencies. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/199bbdb40f1261629067e58577348f7adb5bf837 Cr-Commit-Position: refs/heads/master@{#32351}

Patch Set 1 #

Patch Set 2 : Eliminate one more dep #

Patch Set 3 : BUILD.gn #

Patch Set 4 : Adjust header guards #

Patch Set 5 : Don't move json-stringifier to parsing/ #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -32982 lines) Patch
M BUILD.gn View 1 2 3 4 5 10 chunks +42 lines, -42 lines 0 comments Download
M src/allocation-site-scopes.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/codegen-arm64.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
D src/ast.h View 1 2 3 4 5 1 chunk +0 lines, -3675 lines 0 comments Download
D src/ast.cc View 1 2 3 4 5 1 chunk +0 lines, -1152 lines 0 comments Download
D src/ast-expression-visitor.h View 1 2 3 4 5 1 chunk +0 lines, -50 lines 0 comments Download
D src/ast-expression-visitor.cc View 1 2 3 4 5 1 chunk +0 lines, -398 lines 0 comments Download
D src/ast-literal-reindexer.h View 1 2 3 4 5 1 chunk +0 lines, -45 lines 0 comments Download
D src/ast-literal-reindexer.cc View 1 2 3 4 5 1 chunk +0 lines, -325 lines 0 comments Download
D src/ast-numbering.h View 1 2 3 4 5 1 chunk +0 lines, -25 lines 0 comments Download
D src/ast-numbering.cc View 1 2 3 4 5 1 chunk +0 lines, -592 lines 0 comments Download
D src/ast-value-factory.h View 1 2 3 4 5 1 chunk +0 lines, -376 lines 0 comments Download
D src/ast-value-factory.cc View 1 2 3 4 5 1 chunk +0 lines, -411 lines 0 comments Download
A + src/ast/ast.h View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
A + src/ast/ast.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/ast/ast-expression-visitor.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + src/ast/ast-expression-visitor.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/ast/ast-literal-reindexer.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + src/ast/ast-literal-reindexer.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/ast/ast-numbering.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/ast/ast-numbering.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/ast/ast-value-factory.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/ast/ast-value-factory.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + src/ast/modules.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/ast/modules.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + src/ast/prettyprinter.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + src/ast/prettyprinter.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/ast/scopeinfo.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + src/ast/scopeinfo.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + src/ast/scopes.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + src/ast/scopes.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/ast/variables.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + src/ast/variables.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M src/background-parsing-task.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/bit-vector.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/osr.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/conversions-inl.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen-osr.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/lithium.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/typing.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/typing.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/dateparser.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D src/expression-classifier.h View 1 2 3 4 5 1 chunk +0 lines, -304 lines 0 comments Download
M src/frames.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
D src/func-name-inferrer.h View 1 2 3 4 5 1 chunk +0 lines, -115 lines 0 comments Download
D src/func-name-inferrer.cc View 1 2 3 4 5 1 chunk +0 lines, -85 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
D src/json-parser.h View 1 2 3 4 5 1 chunk +0 lines, -851 lines 0 comments Download
M src/mips/codegen-mips.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/codegen-mips64.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D src/modules.h View 1 2 3 4 5 1 chunk +0 lines, -121 lines 0 comments Download
D src/modules.cc View 1 2 3 4 5 1 chunk +0 lines, -59 lines 0 comments Download
D src/parameter-initializer-rewriter.h View 1 2 3 4 5 1 chunk +0 lines, -22 lines 0 comments Download
D src/parameter-initializer-rewriter.cc View 1 2 3 4 5 1 chunk +0 lines, -82 lines 0 comments Download
D src/parser.h View 1 2 3 4 5 1 chunk +0 lines, -1412 lines 0 comments Download
D src/parser.cc View 1 2 3 4 5 1 chunk +0 lines, -6464 lines 0 comments Download
A + src/parsing/expression-classifier.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + src/parsing/func-name-inferrer.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/parsing/func-name-inferrer.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/parsing/json-parser.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + src/parsing/parameter-initializer-rewriter.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + src/parsing/parameter-initializer-rewriter.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + src/parsing/parser.h View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
A + src/parsing/parser.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
A + src/parsing/pattern-rewriter.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/parsing/preparse-data.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + src/parsing/preparse-data.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/parsing/preparse-data-format.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/parsing/preparser.h View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
A + src/parsing/preparser.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/parsing/rewriter.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/parsing/rewriter.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
A + src/parsing/scanner.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
A + src/parsing/scanner.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
A + src/parsing/scanner-character-streams.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + src/parsing/scanner-character-streams.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + src/parsing/token.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + src/parsing/token.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
D src/pattern-rewriter.cc View 1 2 3 4 5 1 chunk +0 lines, -435 lines 0 comments Download
M src/ppc/codegen-ppc.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D src/preparse-data.h View 1 2 3 4 5 1 chunk +0 lines, -212 lines 0 comments Download
D src/preparse-data.cc View 1 2 3 4 5 1 chunk +0 lines, -80 lines 0 comments Download
D src/preparse-data-format.h View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
D src/preparser.h View 1 2 3 4 5 1 chunk +0 lines, -4262 lines 0 comments Download
D src/preparser.cc View 1 2 3 4 5 1 chunk +0 lines, -1275 lines 0 comments Download
D src/prettyprinter.h View 1 2 3 4 5 1 chunk +0 lines, -139 lines 0 comments Download
D src/prettyprinter.cc View 1 2 3 4 5 1 chunk +0 lines, -1665 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/interpreter-irregexp.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp/regexp-macro-assembler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp-inl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D src/rewriter.h View 1 2 3 4 5 1 chunk +0 lines, -36 lines 0 comments Download
D src/rewriter.cc View 1 2 3 4 5 1 chunk +0 lines, -403 lines 0 comments Download
M src/runtime-profiler.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
D src/scanner.h View 1 2 3 4 5 1 chunk +0 lines, -771 lines 0 comments Download
D src/scanner.cc View 1 2 3 4 5 1 chunk +0 lines, -1673 lines 0 comments Download
D src/scanner-character-streams.h View 1 2 3 4 5 1 chunk +0 lines, -189 lines 0 comments Download
D src/scanner-character-streams.cc View 1 2 3 4 5 1 chunk +0 lines, -588 lines 0 comments Download
D src/scopeinfo.h View 1 2 3 4 5 1 chunk +0 lines, -175 lines 0 comments Download
D src/scopeinfo.cc View 1 2 3 4 5 1 chunk +0 lines, -852 lines 0 comments Download
D src/scopes.h View 1 2 3 4 5 1 chunk +0 lines, -852 lines 0 comments Download
D src/scopes.cc View 1 2 3 4 5 1 chunk +0 lines, -1674 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D src/token.h View 1 2 3 4 5 1 chunk +0 lines, -324 lines 0 comments Download
D src/token.cc View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
M src/type-info.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/typing-asm.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/typing-asm.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing-reset.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/typing-reset.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
D src/variables.h View 1 2 3 4 5 1 chunk +0 lines, -214 lines 0 comments Download
D src/variables.cc View 1 2 3 4 5 1 chunk +0 lines, -82 lines 0 comments Download
M src/x64/codegen-x64.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/x87/codegen-x87.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/expression-type-collector.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/expression-type-collector.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-asm-validator.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/test-ast.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-javascript-arm64.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-js-arm64-variables.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-lockers.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-typing-reset.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 10 chunks +42 lines, -42 lines 0 comments Download
M tools/parser-shell.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
rossberg
5 years ago (2015-11-25 17:37:38 UTC) #1
Michael Starzinger
LGTM. With two high-level comments: 1) Please also adapt the BUILD.gn file. 2) Header guard ...
5 years ago (2015-11-25 18:01:19 UTC) #2
rossberg
> 1) Please also adapt the BUILD.gn file. Done. > 2) Header guard of the ...
5 years ago (2015-11-26 10:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481613002/40001
5 years ago (2015-11-26 11:58:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/12356) v8_linux_dbg on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-11-26 11:59:57 UTC) #8
caitp (gmail)
On 2015/11/26 11:59:57, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-11-26 12:25:25 UTC) #9
rossberg
On 2015/11/26 12:25:25, caitp wrote: > considering the destructuring assignment patch is getting very close ...
5 years ago (2015-11-26 12:41:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481613002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481613002/50001
5 years ago (2015-11-26 14:59:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8198)
5 years ago (2015-11-26 15:27:47 UTC) #15
rossberg
Verwaest, yangguo, adding you as reviewers, as OWNERS of some of the dirs this touches.
5 years ago (2015-11-26 15:41:39 UTC) #18
Toon Verwaest
(rubberstamp) lgtm
5 years ago (2015-11-26 15:51:43 UTC) #19
Yang
On 2015/11/26 15:51:43, Toon Verwaest wrote: > (rubberstamp) lgtm rubberstamp lgtm
5 years ago (2015-11-26 15:53:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481613002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481613002/50001
5 years ago (2015-11-26 16:02:39 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:50001)
5 years ago (2015-11-26 16:22:41 UTC) #24
commit-bot: I haz the power
5 years ago (2015-11-26 16:23:15 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/199bbdb40f1261629067e58577348f7adb5bf837
Cr-Commit-Position: refs/heads/master@{#32351}

Powered by Google App Engine
This is Rietveld 408576698