Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
haraken, adamk
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use stricter typing for HTMLCollection named getter Use stricter typing for HTMLCollection named getter. According to specification, it should return an Element, not a Node. This CL updates the IDL and the native side to explicitly use Element type. There is no Web-Exposed behavior change. The stricter typing just makes clearer what kind of Nodes we are dealing with. R=haraken, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedNodesCollection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAllCollection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 10 months ago (2014-01-28 18:38:43 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-01-28 23:37:11 UTC) #2
Inactive
On 2014/01/28 23:37:11, haraken wrote: > LGTM Thanks. Adamk, could you please take a look ...
6 years, 10 months ago (2014-01-28 23:40:53 UTC) #3
adamk
Source/web/ lgtm
6 years, 10 months ago (2014-01-28 23:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/148013008/1
6 years, 10 months ago (2014-01-29 00:52:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=9633
6 years, 10 months ago (2014-01-29 07:33:08 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 07:33:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/148013008/1
6 years, 10 months ago (2014-01-29 13:18:08 UTC) #8
commit-bot: I haz the power
Change committed as 166041
6 years, 10 months ago (2014-01-29 18:31:26 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 18:34:31 UTC) #10
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698