Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.idl ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormElement.h
diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h
index 552279119d1b06b9a9fc9dc3d2c2f70e2120a7b1..161384ffc1fdf5ad1acbf9b353fa1db1c4c1217d 100644
--- a/Source/core/html/HTMLFormElement.h
+++ b/Source/core/html/HTMLFormElement.h
@@ -51,7 +51,7 @@ public:
virtual ~HTMLFormElement();
PassRefPtr<HTMLCollection> elements();
- void getNamedElements(const AtomicString&, Vector<RefPtr<Node> >&);
+ void getNamedElements(const AtomicString&, Vector<RefPtr<Element> >&);
unsigned length() const;
Node* item(unsigned index);
@@ -115,7 +115,7 @@ public:
const Vector<HTMLImageElement*>& imageElements();
void getTextFieldValues(StringPairVector& fieldNamesAndValues) const;
- void anonymousNamedGetter(const AtomicString& name, bool&, RefPtr<RadioNodeList>&, bool&, RefPtr<Node>&);
+ void anonymousNamedGetter(const AtomicString& name, bool&, RefPtr<RadioNodeList>&, bool&, RefPtr<Element>&);
private:
explicit HTMLFormElement(Document&);
@@ -150,11 +150,11 @@ private:
// are any invalid controls in this form.
bool checkInvalidControlsAndCollectUnhandled(Vector<RefPtr<FormAssociatedElement> >*, HTMLFormControlElement::CheckValidityDispatchEvents = HTMLFormControlElement::CheckValidityDispatchEventsAllowed);
- Node* elementFromPastNamesMap(const AtomicString&);
- void addToPastNamesMap(Node*, const AtomicString& pastName);
+ Element* elementFromPastNamesMap(const AtomicString&);
+ void addToPastNamesMap(Element*, const AtomicString& pastName);
void removeFromPastNamesMap(HTMLElement&);
- typedef HashMap<AtomicString, Node*> PastNamesMap;
+ typedef HashMap<AtomicString, Element*> PastNamesMap;
FormSubmission::Attributes m_attributes;
OwnPtr<PastNamesMap> m_pastNamesMap;
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.idl ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698