Source/core/html/HTMLAllCollection.cpp - Issue 148013008: Use stricter typing for HTMLCollection named getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.cpp

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAllCollection.cpp

diff --git a/Source/core/html/HTMLAllCollection.cpp b/Source/core/html/HTMLAllCollection.cpp

index 9af8d2baa13ae08d3af21fe6a94d51334d2ead0e..1d2a1036a4eb2d0b8a797bcb1ef8c8d5cbb4c3db 100644

--- a/Source/core/html/HTMLAllCollection.cpp

+++ b/Source/core/html/HTMLAllCollection.cpp

@@ -64,9 +64,9 @@ Node* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigned i

return 0;

}

-void HTMLAllCollection::anonymousNamedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Node>& returnValue1)

+void HTMLAllCollection::anonymousNamedGetter(const AtomicString& name, bool& returnValue0Enabled, RefPtr<NodeList>& returnValue0, bool& returnValue1Enabled, RefPtr<Element>& returnValue1)

{

- Vector<RefPtr<Node> > namedItems;

+ Vector<RefPtr<Element> > namedItems;

this->namedItems(name, namedItems);

if (!namedItems.size())

« no previous file with comments | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | no next file with comments »