Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "V8HTMLFormControlsCollection.h" 32 #include "V8HTMLFormControlsCollection.h"
33 33
34 #include "V8Node.h" 34 #include "V8Element.h"
35 #include "V8RadioNodeList.h" 35 #include "V8RadioNodeList.h"
36 #include "bindings/v8/V8Binding.h" 36 #include "bindings/v8/V8Binding.h"
37 #include "core/html/HTMLCollection.h" 37 #include "core/html/HTMLCollection.h"
38 #include "core/html/RadioNodeList.h" 38 #include "core/html/RadioNodeList.h"
39 39
40 namespace WebCore { 40 namespace WebCore {
41 41
42 template<typename CallbackInfo> 42 template<typename CallbackInfo>
43 static v8::Handle<v8::Value> getNamedItems(HTMLFormControlsCollection* collectio n, const AtomicString& name, const CallbackInfo& info) 43 static v8::Handle<v8::Value> getNamedItems(HTMLFormControlsCollection* collectio n, const AtomicString& name, const CallbackInfo& info)
44 { 44 {
45 Vector<RefPtr<Node> > namedItems; 45 Vector<RefPtr<Element> > namedItems;
46 collection->namedItems(name, namedItems); 46 collection->namedItems(name, namedItems);
47 47
48 if (!namedItems.size()) 48 if (!namedItems.size())
49 return v8Undefined(); 49 return v8Undefined();
50 50
51 if (namedItems.size() == 1) 51 if (namedItems.size() == 1)
52 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() ); 52 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() );
53 53
54 return toV8(collection->ownerNode()->radioNodeList(name).get(), info.Holder( ), info.GetIsolate()); 54 return toV8(collection->ownerNode()->radioNodeList(name).get(), info.Holder( ), info.GetIsolate());
55 } 55 }
56 56
57 void V8HTMLFormControlsCollection::namedItemMethodCustom(const v8::FunctionCallb ackInfo<v8::Value>& info) 57 void V8HTMLFormControlsCollection::namedItemMethodCustom(const v8::FunctionCallb ackInfo<v8::Value>& info)
58 { 58 {
59 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, info[0]); 59 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, info[0]);
60 HTMLFormControlsCollection* imp = V8HTMLFormControlsCollection::toNative(inf o.Holder()); 60 HTMLFormControlsCollection* imp = V8HTMLFormControlsCollection::toNative(inf o.Holder());
61 v8::Handle<v8::Value> result = getNamedItems(imp, name, info); 61 v8::Handle<v8::Value> result = getNamedItems(imp, name, info);
62 62
63 if (result.IsEmpty()) { 63 if (result.IsEmpty()) {
64 v8SetReturnValueNull(info); 64 v8SetReturnValueNull(info);
65 return; 65 return;
66 } 66 }
67 67
68 v8SetReturnValue(info, result); 68 v8SetReturnValue(info, result);
69 } 69 }
70 70
71 } // namespace WebCore 71 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698