Source/core/html/HTMLCollection.cpp - Issue 148013008: Use stricter typing for HTMLCollection named getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCollection.cpp

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCollection.cpp

diff --git a/Source/core/html/HTMLCollection.cpp b/Source/core/html/HTMLCollection.cpp

index 103efabd3e558610b093314e26ed079158043ff3..74a2ccf0becf9cf5c154c9dea46a34c189ff9430 100644

--- a/Source/core/html/HTMLCollection.cpp

+++ b/Source/core/html/HTMLCollection.cpp

@@ -578,7 +578,7 @@ inline Element* HTMLCollection::traverseForwardToOffset(unsigned offset, Element

return traverseMatchingElementsForwardToOffset(*this, offset, currentElement, currentOffset, root);

}

-Node* HTMLCollection::namedItem(const AtomicString& name) const

+Element* HTMLCollection::namedItem(const AtomicString& name) const

{

// http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/nameditem.asp

// This method first searches for an object with a matching id

@@ -628,7 +628,7 @@ void HTMLCollection::updateNameCache() const

setHasNameCache();

}

-void HTMLCollection::namedItems(const AtomicString& name, Vector<RefPtr<Node> >& result) const

+void HTMLCollection::namedItems(const AtomicString& name, Vector<RefPtr<Element> >& result) const

{

ASSERT(result.isEmpty());

if (name.isEmpty())

« no previous file with comments | « Source/core/html/HTMLCollection.h ('k') | Source/core/html/HTMLCollection.idl » ('j') | no next file with comments »