Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp - Issue 148013008: Use stricter typing for HTMLCollection named getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

Issue 148013008: Use stricter typing for HTMLCollection named getter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

index ab84454965fc77005173303993529741bf7aaee2..c47052f62c230b96c27c4940e8b66962982790ac 100644

--- a/Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

@@ -31,7 +31,7 @@

#include "config.h"

#include "V8HTMLFormControlsCollection.h"

-#include "V8Node.h"

+#include "V8Element.h"

#include "V8RadioNodeList.h"

#include "bindings/v8/V8Binding.h"

#include "core/html/HTMLCollection.h"

@@ -42,7 +42,7 @@ namespace WebCore {

template<typename CallbackInfo>

static v8::Handle<v8::Value> getNamedItems(HTMLFormControlsCollection* collection, const AtomicString& name, const CallbackInfo& info)

{

- Vector<RefPtr<Node> > namedItems;

+ Vector<RefPtr<Element> > namedItems;

collection->namedItems(name, namedItems);

if (!namedItems.size())