Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Correct parsing of regular expression literal flags. ES6 section 12.2.8.1 states that flags for regular expression literals must be checked during parsing and invalid flags are early errors. This change adapts the Scanner and (Pre)Parser to act according to the spec. This is also a prerequisite to unify the handling of literal creation (for Objects, Arrays, Regexps, and at some point Classes). R=yangguo@chromium.org Committed: https://crrev.com/2732a6ad447b76ee0b74753c3452e28127d574d8 Cr-Commit-Position: refs/heads/master@{#32273}

Patch Set 1 #

Patch Set 2 : Fix oversight in interpreter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -206 lines) Patch
M src/api.cc View 2 chunks +14 lines, -28 lines 0 comments Download
M src/ast.h View 3 chunks +7 lines, -11 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +10 lines, -19 lines 0 comments Download
M src/objects.h View 4 chunks +14 lines, -20 lines 0 comments Download
M src/objects.cc View 4 chunks +62 lines, -38 lines 0 comments Download
M src/preparser.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +20 lines, -3 lines 0 comments Download
M src/regexp/jsregexp.cc View 2 chunks +12 lines, -15 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scanner.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/scanner.cc View 1 chunk +27 lines, -6 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +21 lines, -26 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +1 line, -2 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years ago (2015-11-25 13:06:36 UTC) #1
Benedikt Meurer
Hey Yang, Here's the fixup for regexp literal flags. Please take a look. Thanks, Benedikt
5 years ago (2015-11-25 13:07:43 UTC) #2
Yang
LGTM!
5 years ago (2015-11-25 13:35:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472323002/20001
5 years ago (2015-11-25 13:42:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 13:46:18 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2732a6ad447b76ee0b74753c3452e28127d574d8 Cr-Commit-Position: refs/heads/master@{#32273}
5 years ago (2015-11-25 13:46:53 UTC) #7
Michael Achenbach
5 years ago (2015-11-25 15:06:12 UTC) #8
Message was sent while issue was closed.
Can this have led to this flaky timeout?
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%...

Powered by Google App Engine
This is Rietveld 408576698