Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: src/prettyprinter.cc

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix oversight in interpreter Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/preparser.h ('k') | src/regexp/jsregexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/prettyprinter.cc
diff --git a/src/prettyprinter.cc b/src/prettyprinter.cc
index be241162dd73f99a15b5598ef1d3627b1f7fd9e7..b659b2c8361c6187820d9c3becff75597816a030 100644
--- a/src/prettyprinter.cc
+++ b/src/prettyprinter.cc
@@ -247,7 +247,11 @@ void CallPrinter::VisitRegExpLiteral(RegExpLiteral* node) {
Print("/");
PrintLiteral(node->pattern(), false);
Print("/");
- PrintLiteral(node->flags(), false);
+ if (node->flags() & RegExp::kGlobal) Print("g");
+ if (node->flags() & RegExp::kIgnoreCase) Print("i");
+ if (node->flags() & RegExp::kMultiline) Print("m");
+ if (node->flags() & RegExp::kUnicode) Print("u");
+ if (node->flags() & RegExp::kSticky) Print("y");
}
@@ -738,7 +742,11 @@ void PrettyPrinter::VisitRegExpLiteral(RegExpLiteral* node) {
Print(" RegExp(");
PrintLiteral(node->pattern(), false);
Print(",");
- PrintLiteral(node->flags(), false);
+ if (node->flags() & RegExp::kGlobal) Print("g");
+ if (node->flags() & RegExp::kIgnoreCase) Print("i");
+ if (node->flags() & RegExp::kMultiline) Print("m");
+ if (node->flags() & RegExp::kUnicode) Print("u");
+ if (node->flags() & RegExp::kSticky) Print("y");
Print(") ");
}
@@ -1470,7 +1478,16 @@ void AstPrinter::VisitRegExpLiteral(RegExpLiteral* node) {
SNPrintF(buf, "literal_index = %d\n", node->literal_index());
PrintIndented(buf.start());
PrintLiteralIndented("PATTERN", node->pattern(), false);
- PrintLiteralIndented("FLAGS", node->flags(), false);
+ int i = 0;
+ if (node->flags() & RegExp::kGlobal) buf[i++] = 'g';
+ if (node->flags() & RegExp::kIgnoreCase) buf[i++] = 'i';
+ if (node->flags() & RegExp::kMultiline) buf[i++] = 'm';
+ if (node->flags() & RegExp::kUnicode) buf[i++] = 'u';
+ if (node->flags() & RegExp::kSticky) buf[i++] = 'y';
+ buf[i] = '\0';
+ PrintIndented("FLAGS ");
+ Print(buf.start());
+ Print("\n");
}
« no previous file with comments | « src/preparser.h ('k') | src/regexp/jsregexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698