src/full-codegen/x87/full-codegen-x87.cc - Issue 1472323002: [es6] Correct parsing of regular expression literal flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix oversight in interpreter Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x87/full-codegen-x87.cc

diff --git a/src/full-codegen/x87/full-codegen-x87.cc b/src/full-codegen/x87/full-codegen-x87.cc

index c3e52b192979c15a017c11fa9f5a8d310964acd8..854a6a5809c5b0f82599fd6b365e352416d1c0dd 100644

--- a/src/full-codegen/x87/full-codegen-x87.cc

+++ b/src/full-codegen/x87/full-codegen-x87.cc

@@ -1380,7 +1380,7 @@ void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {

__ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));

__ Move(eax, Immediate(Smi::FromInt(expr->literal_index())));

__ Move(ecx, Immediate(expr->pattern()));

- __ Move(edx, Immediate(expr->flags()));

+ __ Move(edx, Immediate(Smi::FromInt(expr->flags())));

FastCloneRegExpStub stub(isolate());

__ CallStub(&stub);

context()->Plug(eax);

« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »