src/runtime/runtime-regexp.cc - Issue 1472323002: [es6] Correct parsing of regular expression literal flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-regexp.cc

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix oversight in interpreter Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-regexp.cc

diff --git a/src/runtime/runtime-regexp.cc b/src/runtime/runtime-regexp.cc

index f2b1b23322d4a93d80b8ec0e2f8e72f8fcbb4c52..138b4dc71c4a1b91e4055fce1af40c33350d8cf0 100644

--- a/src/runtime/runtime-regexp.cc

+++ b/src/runtime/runtime-regexp.cc

@@ -658,7 +658,7 @@ RUNTIME_FUNCTION(Runtime_StringReplaceGlobalRegExpWithString) {

CONVERT_ARG_HANDLE_CHECKED(JSRegExp, regexp, 1);

CONVERT_ARG_HANDLE_CHECKED(JSArray, last_match_info, 3);

- RUNTIME_ASSERT(regexp->GetFlags().is_global());

+ RUNTIME_ASSERT(regexp->GetFlags() & JSRegExp::kGlobal);

RUNTIME_ASSERT(last_match_info->HasFastObjectElements());

subject = String::Flatten(subject);

@@ -1000,7 +1000,7 @@ RUNTIME_FUNCTION(Runtime_RegExpExecMultiple) {

RUNTIME_ASSERT(result_array->HasFastObjectElements());

subject = String::Flatten(subject);

- RUNTIME_ASSERT(regexp->GetFlags().is_global());

+ RUNTIME_ASSERT(regexp->GetFlags() & JSRegExp::kGlobal);

if (regexp->CaptureCount() == 0) {

return SearchRegExpMultiple<false>(isolate, subject, regexp,

« no previous file with comments | « src/runtime/runtime-literals.cc ('k') | src/scanner.h » ('j') | no next file with comments »