src/full-codegen/arm64/full-codegen-arm64.cc - Issue 1472323002: [es6] Correct parsing of regular expression literal flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix oversight in interpreter Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/arm64/full-codegen-arm64.cc

diff --git a/src/full-codegen/arm64/full-codegen-arm64.cc b/src/full-codegen/arm64/full-codegen-arm64.cc

index 0ab43be7770037865671ee96aec369388a97f93c..10b4dc11330348929a817331afd16b23c85e394f 100644

--- a/src/full-codegen/arm64/full-codegen-arm64.cc

+++ b/src/full-codegen/arm64/full-codegen-arm64.cc

@@ -1453,7 +1453,7 @@ void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {

__ Ldr(x3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));

__ Mov(x2, Smi::FromInt(expr->literal_index()));

__ Mov(x1, Operand(expr->pattern()));

- __ Mov(x0, Operand(expr->flags()));

+ __ Mov(x0, Smi::FromInt(expr->flags()));

FastCloneRegExpStub stub(isolate());

__ CallStub(&stub);

context()->Plug(x0);

« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »