Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1472323002: [es6] Correct parsing of regular expression literal flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix oversight in interpreter Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
1373 } 1373 }
1374 } 1374 }
1375 } 1375 }
1376 1376
1377 1377
1378 void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) { 1378 void FullCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {
1379 Comment cmnt(masm_, "[ RegExpLiteral"); 1379 Comment cmnt(masm_, "[ RegExpLiteral");
1380 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 1380 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
1381 __ Move(eax, Immediate(Smi::FromInt(expr->literal_index()))); 1381 __ Move(eax, Immediate(Smi::FromInt(expr->literal_index())));
1382 __ Move(ecx, Immediate(expr->pattern())); 1382 __ Move(ecx, Immediate(expr->pattern()));
1383 __ Move(edx, Immediate(expr->flags())); 1383 __ Move(edx, Immediate(Smi::FromInt(expr->flags())));
1384 FastCloneRegExpStub stub(isolate()); 1384 FastCloneRegExpStub stub(isolate());
1385 __ CallStub(&stub); 1385 __ CallStub(&stub);
1386 context()->Plug(eax); 1386 context()->Plug(eax);
1387 } 1387 }
1388 1388
1389 1389
1390 void FullCodeGenerator::EmitAccessor(ObjectLiteralProperty* property) { 1390 void FullCodeGenerator::EmitAccessor(ObjectLiteralProperty* property) {
1391 Expression* expression = (property == NULL) ? NULL : property->value(); 1391 Expression* expression = (property == NULL) ? NULL : property->value();
1392 if (expression == NULL) { 1392 if (expression == NULL) {
1393 __ push(Immediate(isolate()->factory()->null_value())); 1393 __ push(Immediate(isolate()->factory()->null_value()));
(...skipping 3469 matching lines...) Expand 10 before | Expand all | Expand 10 after
4863 Assembler::target_address_at(call_target_address, 4863 Assembler::target_address_at(call_target_address,
4864 unoptimized_code)); 4864 unoptimized_code));
4865 return OSR_AFTER_STACK_CHECK; 4865 return OSR_AFTER_STACK_CHECK;
4866 } 4866 }
4867 4867
4868 4868
4869 } // namespace internal 4869 } // namespace internal
4870 } // namespace v8 4870 } // namespace v8
4871 4871
4872 #endif // V8_TARGET_ARCH_X87 4872 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698