New build flag system, convert Google Now flag

New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit define.

Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").

Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org

Committed: https://crrev.com/06c2ba3165d8b02364bf818d5028a7cb4fe48ac0
Cr-Commit-Position: refs/heads/master@{#361854}

[brettw, 2015-11-25 23:13:57]

Description was changed from

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.
==========

to

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
==========

[brettw, 2015-11-25 23:13:57]

brettw@chromium.org changed reviewers:
+ mark@chromium.org

[brettw, 2015-11-25 23:14:19]

PS1 is previous landing, PS2 is added dependencies from chrome constants.

[brettw, 2015-11-25 23:14:23]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-25 23:15:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469383005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469383005/20001

[Mark Mentovai, 2015-11-26 00:42:40]

LGTM

[commit-bot: I haz the power, 2015-11-26 01:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 01:21:12]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[brettw, 2015-11-26 01:25:33]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-26 01:27:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469383005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469383005/20001

[commit-bot: I haz the power, 2015-11-26 03:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 03:30:07]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[brettw, 2015-11-26 06:57:45]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-11-26 06:57:46]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1469383005/#ps40001
(title: "make separate gyp to avoid cycle")

[commit-bot: I haz the power, 2015-11-26 06:58:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469383005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469383005/40001

[commit-bot: I haz the power, 2015-11-26 09:21:32]

Description was changed from

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
==========

to

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
==========

[commit-bot: I haz the power, 2015-11-26 09:21:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-26 09:22:36]

Description was changed from

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
==========

to

==========
New build flag system, convert Google Now flag

This generates headers with build flags rather than forcing them all to be
global. It includes an accessor wrapper so that references to the flags will
fail if the proper header is not included.

Converts Google Now to use this and remove the global google now define and grit
define.

Adds support for grit define values of "true" and "false" for ease of
integration with GN (they are mapped to the corresponding Python "True" and
"False").

Adds dependencies from the main gyp targets to the new generated feature define
target. Since GYP only does hard dependencies one level, this should reduce the
chance that somebody adds more of these cases and forces to add a dependency.

Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org

Committed: https://crrev.com/06c2ba3165d8b02364bf818d5028a7cb4fe48ac0
Cr-Commit-Position: refs/heads/master@{#361854}
==========

[commit-bot: I haz the power, 2015-11-26 09:22:37]

Patchset 3 (id:??) landed as
https://crrev.com/06c2ba3165d8b02364bf818d5028a7cb4fe48ac0
Cr-Commit-Position: refs/heads/master@{#361854}

[Dan Beam, 2015-12-31 03:08:37]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-12-31 03:08:38]

https://codereview.chromium.org/1469383005/diff/40001/chrome/chrome_resources...
File chrome/chrome_resources.gyp (right):

https://codereview.chromium.org/1469383005/diff/40001/chrome/chrome_resources...
chrome/chrome_resources.gyp:197: 'grit_additional_defines': [
this blocks <@(chrome_grit_defines) (and hence: -D "enable_google_now=1") from
being passed along while generating browser_resources.grd.

noticed while scraping through out/Release/obj/chrome/chrome_resources.ninja to
determine why my BUILDFLAG(use_vulcanize) CL[1] wasn't working :(

[1] https://codereview.chromium.org/1494253003/