build/config/BUILD.gn - Issue 1469383005: New build flag system, convert Google Now flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1469383005: New build flag system, convert Google Now flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make separate gyp to avoid cycle Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 9cc3756bc2f5827ecb0e9a6f930f6902c5f11e57..5f857139a409755ab0cfc8265ca46d2e31fff08e 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -218,9 +218,6 @@ config("feature_flags") {

if (enable_image_loader_extension) {

defines += [ "IMAGE_LOADER_EXTENSION=1" ]

}

- if (enable_google_now) {

- defines += [ "ENABLE_GOOGLE_NOW=1" ]

- }

if (enable_one_click_signin) {

defines += [ "ENABLE_ONE_CLICK_SIGNIN" ]

}