Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3930)

Unified Diff: chrome/common/BUILD.gn

Issue 1469383005: New build flag system, convert Google Now flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make separate gyp to avoid cycle Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 0e8b05436d144b5de72c55a7d035f37ad4ffd107..d0cbe2a42674f71583631986b7fd5e0fb4930897 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/buildflag_header.gni")
+import("//chrome/common/features.gni")
import("//chrome/version.gni")
import("//mojo/public/tools/bindings/mojom.gni")
import("//tools/grit/grit_rule.gni")
@@ -36,6 +38,11 @@ if (enable_extensions) {
}
}
+buildflag_header("features") {
+ header = "features.h"
+ flags = [ "ENABLE_GOOGLE_NOW=$enable_google_now" ]
+}
+
# GYP version: chrome/chrome_common.gypi:common
static_library("common") {
sources = rebase_path(gypi_values.chrome_common_sources, ".", "//chrome")
@@ -47,6 +54,7 @@ static_library("common") {
]
public_deps = [
+ ":features",
"//base:base",
"//base:base_static",
"//base:i18n",
@@ -316,6 +324,7 @@ static_library("constants") {
"//content/public/common:result_codes",
]
deps = [
+ ":features",
":version_header",
"//base",
"//base/third_party/dynamic_annotations",

Powered by Google App Engine
This is Rietveld 408576698