Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4969)

Unified Diff: chrome/common_constants.gyp

Issue 1469383005: New build flag system, convert Google Now flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make separate gyp to avoid cycle Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common_constants.gyp
diff --git a/chrome/common_constants.gyp b/chrome/common_constants.gyp
index 134878ea22c8cef373885c55c398a0a40d6be6d3..a8d701fe21a69c1fdc28b43f2c7a51a512f6d863 100644
--- a/chrome/common_constants.gyp
+++ b/chrome/common_constants.gyp
@@ -72,6 +72,7 @@
# GN version: //chrome/common:constants
'target_name': 'common_constants',
'type': 'static_library',
+ 'hard_dependency': 1, # Because of transitive dep on version_header.
'sources': [
'<@(common_constants_sources)'
],
@@ -80,6 +81,7 @@
],
'dependencies': [
'version_header',
+ 'chrome_features.gyp:chrome_common_features',
'../base/base.gyp:base',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../components/components.gyp:bookmarks_common',
@@ -108,6 +110,7 @@
'targets': [
{
'target_name': 'common_constants_win64',
+ 'hard_dependency': 1, # Because of transitive dep on version_header.
'type': 'static_library',
'sources': [
'<@(common_constants_sources)'
@@ -117,6 +120,7 @@
],
'dependencies': [
'version_header',
+ 'chrome_features.gyp:chrome_common_features',
'../base/base.gyp:base_win64',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations_win64',
'../components/nacl.gyp:nacl_switches_win64',

Powered by Google App Engine
This is Rietveld 408576698