Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/common_constants.gyp

Issue 1469383005: New build flag system, convert Google Now flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make separate gyp to avoid cycle Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 'common_constants_sources': [ 8 'common_constants_sources': [
9 'common/chrome_constants.cc', 9 'common/chrome_constants.cc',
10 'common/chrome_constants.h', 10 'common/chrome_constants.h',
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 '<@(_outputs)', 65 '<@(_outputs)',
66 ], 66 ],
67 'message': 'Generating version header file: <@(_outputs)', 67 'message': 'Generating version header file: <@(_outputs)',
68 }, 68 },
69 ], 69 ],
70 }, 70 },
71 { 71 {
72 # GN version: //chrome/common:constants 72 # GN version: //chrome/common:constants
73 'target_name': 'common_constants', 73 'target_name': 'common_constants',
74 'type': 'static_library', 74 'type': 'static_library',
75 'hard_dependency': 1, # Because of transitive dep on version_header.
75 'sources': [ 76 'sources': [
76 '<@(common_constants_sources)' 77 '<@(common_constants_sources)'
77 ], 78 ],
78 'include_dirs': [ 79 'include_dirs': [
79 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc. 80 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc.
80 ], 81 ],
81 'dependencies': [ 82 'dependencies': [
82 'version_header', 83 'version_header',
84 'chrome_features.gyp:chrome_common_features',
83 '../base/base.gyp:base', 85 '../base/base.gyp:base',
84 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic _annotations', 86 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic _annotations',
85 '../components/components.gyp:bookmarks_common', 87 '../components/components.gyp:bookmarks_common',
86 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h', 88 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
87 ], 89 ],
88 'target_conditions': [ 90 'target_conditions': [
89 ['OS=="ios"', { 91 ['OS=="ios"', {
90 # iOS needs chrome_paths_mac, which is excluded by filename rules; 92 # iOS needs chrome_paths_mac, which is excluded by filename rules;
91 # re-add it in target_conditionals so it's after that exclusion. 93 # re-add it in target_conditionals so it's after that exclusion.
92 'sources/': [ 94 'sources/': [
93 ['include', '^common/chrome_paths_mac\\.mm$'], 95 ['include', '^common/chrome_paths_mac\\.mm$'],
94 ], 96 ],
95 }], 97 }],
96 ], 98 ],
97 'conditions': [ 99 'conditions': [
98 ['disable_nacl==0', { 100 ['disable_nacl==0', {
99 'dependencies': [ 101 'dependencies': [
100 '../components/nacl.gyp:nacl_switches', 102 '../components/nacl.gyp:nacl_switches',
101 ], 103 ],
102 }], 104 }],
103 ], 105 ],
104 }, 106 },
105 ], 107 ],
106 'conditions': [ 108 'conditions': [
107 ['OS=="win" and target_arch=="ia32"', { 109 ['OS=="win" and target_arch=="ia32"', {
108 'targets': [ 110 'targets': [
109 { 111 {
110 'target_name': 'common_constants_win64', 112 'target_name': 'common_constants_win64',
113 'hard_dependency': 1, # Because of transitive dep on version_header.
111 'type': 'static_library', 114 'type': 'static_library',
112 'sources': [ 115 'sources': [
113 '<@(common_constants_sources)' 116 '<@(common_constants_sources)'
114 ], 117 ],
115 'include_dirs': [ 118 'include_dirs': [
116 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc. 119 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc.
117 ], 120 ],
118 'dependencies': [ 121 'dependencies': [
119 'version_header', 122 'version_header',
123 'chrome_features.gyp:chrome_common_features',
120 '../base/base.gyp:base_win64', 124 '../base/base.gyp:base_win64',
121 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dyn amic_annotations_win64', 125 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dyn amic_annotations_win64',
122 '../components/nacl.gyp:nacl_switches_win64', 126 '../components/nacl.gyp:nacl_switches_win64',
123 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h ', 127 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h ',
124 ], 128 ],
125 'defines': [ 129 'defines': [
126 '<@(nacl_win64_defines)', 130 '<@(nacl_win64_defines)',
127 'COMPILE_CONTENT_STATICALLY', 131 'COMPILE_CONTENT_STATICALLY',
128 ], 132 ],
129 'configurations': { 133 'configurations': {
130 'Common_Base': { 134 'Common_Base': {
131 'msvs_target_platform': 'x64', 135 'msvs_target_platform': 'x64',
132 }, 136 },
133 }, 137 },
134 }, 138 },
135 ], 139 ],
136 }], 140 }],
137 ], 141 ],
138 } 142 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698