MD Downloads: add a use_vulcanize option to Chrome

MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize=0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary

Committed: https://crrev.com/64eba5b39620df70320fd0d23e4ba85022670203
Cr-Commit-Position: refs/heads/master@{#367226}

[Dan Beam, 2015-12-03 21:52:22]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  # For a single build.
  build/gyp_chromium -Duse_vulcanize=0

OR

  # To set up more permanently, possibly in your .bash_profile.
  export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  # For a single build.
  build/gyp_chromium -Duse_vulcanize=0

OR

  # To set up more permanently, possibly in your .bash_profile.
  export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-03 21:52:35]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  # For a single build.
  build/gyp_chromium -Duse_vulcanize=0

OR

  # To set up more permanently, possibly in your .bash_profile.
  export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  # For a single build.
  build/gyp_chromium -Duse_vulcanize=0

OR

  # To set up more permanently, possibly in your .bash_profile.
  export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-03 21:53:20]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  # For a single build.
  build/gyp_chromium -Duse_vulcanize=0

OR

  # To set up more permanently, possibly in your .bash_profile.
  export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-03 22:02:28]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-12-03 22:06:33]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2015-12-03 22:14:28]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_goma=1 component=shared_library clang=1',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-03 22:21:44]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="${GYP_DEFINES} use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-03 22:22:30]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently only the new Material Design downloads page uses Vulcanize,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[groby-ooo-7-16, 2015-12-04 22:23:33]

lgtm

https://codereview.chromium.org/1494253003/diff/40001/chrome/browser/browser_...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/1494253003/diff/40001/chrome/browser/browser_...
chrome/browser/browser_resources.grd:31: <if expr="not use_vulcanize">
The grd_reader unittest claims we have <else>...

[Dan Beam, 2015-12-05 02:21:41]

dbeam@chromium.org changed reviewers:
+ thakis@chromium.org

[Dan Beam, 2015-12-05 02:21:41]

+thakis@ for build/

https://codereview.chromium.org/1494253003/diff/40001/chrome/browser/browser_...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/1494253003/diff/40001/chrome/browser/browser_...
chrome/browser/browser_resources.grd:31: <if expr="not use_vulcanize">
On 2015/12/04 22:23:33, groby wrote:
> The grd_reader unittest claims we have <else>... 

yeah, but it adds more tags and more indent.  can use if you really want, I just
have rebuild the world everytime I touch this CL

[groby-ooo-7-16, 2015-12-07 21:17:28]

On 2015/12/05 02:21:41, Dan Beam wrote:
> +thakis@ for build/
> 
>
https://codereview.chromium.org/1494253003/diff/40001/chrome/browser/browser_...
> File chrome/browser/browser_resources.grd (right):
> 
>
https://codereview.chromium.org/1494253003/diff/40001/chrome/browser/browser_...
> chrome/browser/browser_resources.grd:31: <if expr="not use_vulcanize">
> On 2015/12/04 22:23:33, groby wrote:
> > The grd_reader unittest claims we have <else>... 
> 
> yeah, but it adds more tags and more indent.  can use if you really want, I
just
> have rebuild the world everytime I touch this CL

Meh. Nobody uses it, and it only upsets my personal code OCD, so leave as is :)

[Nico, 2015-12-07 21:29:13]

https://codereview.chromium.org/1494253003/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1494253003/diff/40001/build/common.gypi#newco...
build/common.gypi:717: 'use_vulcanize%': 1,
1. Do you need to do this in gn too?
2. Have you seen "[chromium-dev] Intent to implement: New feature flags system
for the bulid" (sic)? This is now being implemented, maybe it could be used for
this too. (See brettw's recent Google Now feature CL for an example)

[Dan Beam, 2015-12-30 05:05:39]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #if defined(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"

  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-30 05:07:52]

https://codereview.chromium.org/1494253003/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1494253003/diff/40001/build/common.gypi#newco...
build/common.gypi:717: 'use_vulcanize%': 1,
On 2015/12/07 21:29:13, Nico wrote:
> 1. Do you need to do this in gn too?
> 2. Have you seen "[chromium-dev] Intent to implement: New feature flags system
> for the bulid" (sic)? This is now being implemented, maybe it could be used
for
> this too. (See brettw's recent Google Now feature CL for an example)

Done.

[Nico, 2015-12-30 14:29:22]

https://codereview.chromium.org/1494253003/diff/80001/chrome/chrome_features....
File chrome/chrome_features.gypi (right):

https://codereview.chromium.org/1494253003/diff/80001/chrome/chrome_features....
chrome/chrome_features.gypi:25: 'use_vulcanize%': 1,
shouldn't this default to 0?

https://codereview.chromium.org/1494253003/diff/80001/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/1494253003/diff/80001/chrome/common/features....
chrome/common/features.gni:17: use_vulcanize = true
add a comment that explains what this does

[Dan Beam, 2015-12-30 17:11:12]

https://codereview.chromium.org/1494253003/diff/80001/chrome/chrome_features....
File chrome/chrome_features.gypi (right):

https://codereview.chromium.org/1494253003/diff/80001/chrome/chrome_features....
chrome/chrome_features.gypi:25: 'use_vulcanize%': 1,
On 2015/12/30 14:29:22, Nico wrote:
> shouldn't this default to 0?

no

https://codereview.chromium.org/1494253003/diff/80001/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/1494253003/diff/80001/chrome/common/features....
chrome/common/features.gni:17: use_vulcanize = true
On 2015/12/30 14:29:22, Nico wrote:
> add a comment that explains what this does

Done.

[Dan Beam, 2015-12-30 17:16:22]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

This harnesses pre-vulcanized versions of WebUI pages when they're
available for speed.  If you'd like to work on the un-vulcanized version
while developing, do something like:

  $ build/gyp_chromium -Duse_vulcanize=0  # For a single build.

OR

  # To set up more permanently, possibly in your .bash_profile.
  $ export GYP_DEFINES="use_vulcanized=0"
  $ gclient runhooks

OR

  # In src/../chromium.gyp_env or ~/.gyp/includes.
  {
    'GYP_DEFINES': 'use_vulcanize=0',
  }

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"

  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize = 0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-30 17:22:53]

https://codereview.chromium.org/1494253003/diff/80001/chrome/chrome_features....
File chrome/chrome_features.gypi (right):

https://codereview.chromium.org/1494253003/diff/80001/chrome/chrome_features....
chrome/chrome_features.gypi:25: 'use_vulcanize%': 1,
On 2015/12/30 17:11:12, Dan Beam wrote:
> On 2015/12/30 14:29:22, Nico wrote:
> > shouldn't this default to 0?
> 
> no

i only asked you to review part of this CL, so you may not have a great idea of
the bigger picture here.  i've updated the CL description, which will hopefully
help, but just to make sure...

right chrome contains:
1) the old downloads page
2) a debug version of the new downloads page
3) a vulcanized version of the downloads page

eventually it should only contain:
1) a vulcanized version of the new (and only) downloads page

steps to get to here ^:
1) land this CL to make debug and vulcanized versions mutually exclusive
2) remove the old version when we're shipped

i assume both ^ these steps to remove code will help with size

[Nico, 2015-12-30 19:17:41]

This CL looks good to me.

Your description confuses me a bit though. Usually, new features are added
behind a flag, and when the flag is off the old version is used but not the new
one, and when it's on the new version is used but not the old one. Toggling the
flag then flips between the two versions, so that they can be compared.

It sounds as if both old and new where active at the same time, making it
impossible to compare old and new (so that they can be toggled at runtime, I
suppose). Can you locally hack up how much removing the old stuff would help
with binary size?

[Dan Beam, 2015-12-30 19:19:47]

On 2015/12/30 19:17:41, Nico wrote:
> This CL looks good to me.
> 
> Your description confuses me a bit though. Usually, new features are added
> behind a flag, and when the flag is off the old version is used but not the
new
> one, and when it's on the new version is used but not the old one. Toggling
the
> flag then flips between the two versions, so that they can be compared.

the debug and vulcanized copies of downloads have been in chrome for a while. 
removing the debug version is new.

> 
> It sounds as if both old and new where active at the same time, making it
> impossible to compare old and new (so that they can be toggled at runtime, I
> suppose). Can you locally hack up how much removing the old stuff would help
> with binary size?

are active**

https://code.google.com/p/chromium/issues/detail?id=541455#c12

[Nico, 2015-12-30 19:25:32]

On 2015/12/30 19:19:47, Dan Beam wrote:
> On 2015/12/30 19:17:41, Nico wrote:
> > This CL looks good to me.
> > 
> > Your description confuses me a bit though. Usually, new features are added
> > behind a flag, and when the flag is off the old version is used but not the
> new
> > one, and when it's on the new version is used but not the old one. Toggling
> the
> > flag then flips between the two versions, so that they can be compared.
> 
> the debug and vulcanized copies of downloads have been in chrome for a while. 
> removing the debug version is new.

Yes, I understand that. I'm just confused that this was apparently put in place
without measuring the binary hit of having just a vulcanized version in place
before committing to this strategy.

> 
> > 
> > It sounds as if both old and new where active at the same time, making it
> > impossible to compare old and new (so that they can be toggled at runtime, I
> > suppose). Can you locally hack up how much removing the old stuff would help
> > with binary size?
> 
> are active**
> 
> https://code.google.com/p/chromium/issues/detail?id=541455#c12

Yes, understood, just phrased poorly. (misspelled "were" when I really meant
"are")

[Dan Beam, 2015-12-30 19:45:28]

On 2015/12/30 19:25:32, Nico wrote:
> On 2015/12/30 19:19:47, Dan Beam wrote:
> > On 2015/12/30 19:17:41, Nico wrote:
> > > This CL looks good to me.
> > > 
> > > Your description confuses me a bit though. Usually, new features are added
> > > behind a flag, and when the flag is off the old version is used but not
the
> > new
> > > one, and when it's on the new version is used but not the old one.
Toggling
> > the
> > > flag then flips between the two versions, so that they can be compared.
> > 
> > the debug and vulcanized copies of downloads have been in chrome for a
while. 
> > removing the debug version is new.
> 
> Yes, I understand that. I'm just confused that this was apparently put in
place
> without measuring the binary hit of having just a vulcanized version in place
> before committing to this strategy.

I thought:
* duplicate resources would be de-duped by installer compression
* I'd get notified by sizes breaks in less than 1+ month if not

> 
> > 
> > > 
> > > It sounds as if both old and new where active at the same time, making it
> > > impossible to compare old and new (so that they can be toggled at runtime,
I
> > > suppose). Can you locally hack up how much removing the old stuff would
help
> > > with binary size?
> > 
> > are active**
> > 
> > https://code.google.com/p/chromium/issues/detail?id=541455#c12
> 
> Yes, understood, just phrased poorly. (misspelled "were" when I really meant
> "are")

so what else do you need for this CL?

[Nico, 2015-12-30 19:53:44]

nothing, as I said this cl lgtm, go ahead and cq :-) I'm just a bit confused by
the CL's context.

[Nico, 2015-12-30 19:53:52]

(less confused now though, thanks!)

[Dan Beam, 2015-12-31 02:21:53]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize = 0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize=0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary
==========

[Dan Beam, 2015-12-31 03:23:00]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-12-31 03:23:00]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1494253003/#ps120001
(title: "fix")

[commit-bot: I haz the power, 2015-12-31 03:23:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494253003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494253003/120001

[commit-bot: I haz the power, 2015-12-31 04:06:12]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize=0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize=0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary
==========

[commit-bot: I haz the power, 2015-12-31 04:06:12]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-12-31 04:07:22]

Description was changed from

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize=0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary
==========

to

==========
MD Downloads: add a use_vulcanize option to Chrome

use_vulcanize is on by default. This means that release, official,
and debug builds that don't need debug versions of webui pages will
get the fastest experience.

To turn off vulcanization for local development, set

  use_vulcanize=0

in GYP, or

  use_vulcanize = false

in GN.

To conditionally include files in .grd files, do:

  <if expr="use_vulcanize">

and in C++:

  #include "chrome/common/features.h"
  #if BUILDFLAG(USE_VULCANIZE)

Currently, only the new Material Design downloads page is vulcanized,
but there will soon be others.

R=groby@chromium.org,thakis@chromium.org
BUG=541455
TEST=smaller binary

Committed: https://crrev.com/64eba5b39620df70320fd0d23e4ba85022670203
Cr-Commit-Position: refs/heads/master@{#367226}
==========

[commit-bot: I haz the power, 2015-12-31 04:07:22]

Patchset 5 (id:??) landed as
https://crrev.com/64eba5b39620df70320fd0d23e4ba85022670203
Cr-Commit-Position: refs/heads/master@{#367226}