Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1468423003: Construct USB descriptors over explicit values. (Closed)

Created:
5 years ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Construct USB descriptors over explicit values. Instead of specifying a bunch of arbitrary defaults and then updating them in the code building the structure. This makes them friendly to use with C++11's emplace_back() method. BUG=None Committed: https://crrev.com/54128082613544e4fa1fb2f0d6a367dea635c173 Cr-Commit-Position: refs/heads/master@{#375081}

Patch Set 1 #

Patch Set 2 : Fix build on Chrome OS. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased, emplace_back is now allowed. #

Patch Set 5 : Update Android code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -152 lines) Patch
M chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 2 3 1 chunk +12 lines, -22 lines 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 1 2 3 2 chunks +4 lines, -9 lines 0 comments Download
M device/usb/usb_configuration_android.cc View 1 2 3 4 1 chunk +5 lines, -9 lines 0 comments Download
M device/usb/usb_descriptors.h View 1 2 3 3 chunks +19 lines, -3 lines 0 comments Download
M device/usb/usb_descriptors.cc View 1 2 3 1 chunk +41 lines, -33 lines 0 comments Download
M device/usb/usb_device_android.cc View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 2 3 3 chunks +20 lines, -26 lines 0 comments Download
M device/usb/usb_endpoint_android.cc View 1 2 3 4 1 chunk +10 lines, -13 lines 0 comments Download
M device/usb/usb_interface_android.cc View 1 2 3 4 1 chunk +6 lines, -11 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 2 3 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years ago (2015-12-10 20:13:21 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years ago (2015-12-11 20:52:39 UTC) #4
Reilly Grant (use Gerrit)
Actually the use of emplace*() is still currently disallowed. I'll wait to see the result ...
5 years ago (2015-12-11 20:55:55 UTC) #5
Reilly Grant (use Gerrit)
dgozman@ please review android_usb_browsertest.cc. stevenjb@ please review printer_detector_unittest.cc.
4 years, 10 months ago (2016-02-12 00:12:21 UTC) #7
stevenjb
RS LGTM
4 years, 10 months ago (2016-02-12 00:21:00 UTC) #8
dgozman
devtools lgtm
4 years, 10 months ago (2016-02-12 00:24:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468423003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468423003/80001
4 years, 10 months ago (2016-02-12 00:37:41 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-12 01:38:45 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:40:38 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/54128082613544e4fa1fb2f0d6a367dea635c173
Cr-Commit-Position: refs/heads/master@{#375081}

Powered by Google App Engine
This is Rietveld 408576698