Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: device/usb/usb_descriptors.h

Issue 1468423003: Construct USB descriptors over explicit values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Android code. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_configuration_android.cc ('k') | device/usb/usb_descriptors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_descriptors.h
diff --git a/device/usb/usb_descriptors.h b/device/usb/usb_descriptors.h
index cd8490aafeeb80ee451c4a7272c22f07ee921562..c99a6def7bf9e3e37c1849517e572bc692a895fe 100644
--- a/device/usb/usb_descriptors.h
+++ b/device/usb/usb_descriptors.h
@@ -49,7 +49,14 @@ enum UsbUsageType {
};
struct UsbEndpointDescriptor {
- UsbEndpointDescriptor();
+ UsbEndpointDescriptor(uint8_t address,
+ UsbEndpointDirection direction,
+ uint16_t maximum_packet_size,
+ UsbSynchronizationType synchronization_type,
+ UsbTransferType transfer_type,
+ UsbUsageType usage_type,
+ uint16_t polling_interval);
+ UsbEndpointDescriptor() = delete;
~UsbEndpointDescriptor();
uint8_t address;
@@ -63,7 +70,12 @@ struct UsbEndpointDescriptor {
};
struct UsbInterfaceDescriptor {
- UsbInterfaceDescriptor();
+ UsbInterfaceDescriptor(uint8_t interface_number,
+ uint8_t alternate_setting,
+ uint8_t interface_class,
+ uint8_t interface_subclass,
+ uint8_t interface_protocol);
+ UsbInterfaceDescriptor() = delete;
~UsbInterfaceDescriptor();
uint8_t interface_number;
@@ -76,7 +88,11 @@ struct UsbInterfaceDescriptor {
};
struct UsbConfigDescriptor {
- UsbConfigDescriptor();
+ UsbConfigDescriptor(uint8_t configuration_value,
+ bool self_powered,
+ bool remote_wakeup,
+ uint16_t maximum_power);
+ UsbConfigDescriptor() = delete;
~UsbConfigDescriptor();
uint8_t configuration_value;
« no previous file with comments | « device/usb/usb_configuration_android.cc ('k') | device/usb/usb_descriptors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698