Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: device/usb/mojo/device_impl_unittest.cc

Issue 1468423003: Construct USB descriptors over explicit values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Android code. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/usb/mojo/device_impl_unittest.cc
diff --git a/device/usb/mojo/device_impl_unittest.cc b/device/usb/mojo/device_impl_unittest.cc
index 626edd912491860d08106218b927ce0e0c5eeea2..ad01d6e9459de2a4c2e2ef0c1929efbf30c27b7d 100644
--- a/device/usb/mojo/device_impl_unittest.cc
+++ b/device/usb/mojo/device_impl_unittest.cc
@@ -37,20 +37,15 @@ namespace {
class ConfigBuilder {
public:
- explicit ConfigBuilder(uint8_t value) { config_.configuration_value = value; }
+ explicit ConfigBuilder(uint8_t value) : config_(value, false, false, 0) {}
ConfigBuilder& AddInterface(uint8_t interface_number,
uint8_t alternate_setting,
uint8_t class_code,
uint8_t subclass_code,
uint8_t protocol_code) {
- UsbInterfaceDescriptor interface;
- interface.interface_number = interface_number;
- interface.alternate_setting = alternate_setting;
- interface.interface_class = class_code;
- interface.interface_subclass = subclass_code;
- interface.interface_protocol = protocol_code;
- config_.interfaces.push_back(interface);
+ config_.interfaces.emplace_back(interface_number, alternate_setting,
+ class_code, subclass_code, protocol_code);
return *this;
}
@@ -219,7 +214,7 @@ class USBDeviceImplTest : public testing::Test {
void AddMockConfig(const ConfigBuilder& builder) {
const UsbConfigDescriptor& config = builder.config();
DCHECK(!ContainsKey(mock_configs_, config.configuration_value));
- mock_configs_[config.configuration_value] = config;
+ mock_configs_.insert(std::make_pair(config.configuration_value, config));
}
void AddMockInboundData(const std::vector<uint8_t>& data) {
« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | device/usb/usb_configuration_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698