Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: device/usb/usb_device_filter_unittest.cc

Issue 1468423003: Construct USB descriptors over explicit values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Android code. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_device_android.cc ('k') | device/usb/usb_device_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_device_filter_unittest.cc
diff --git a/device/usb/usb_device_filter_unittest.cc b/device/usb/usb_device_filter_unittest.cc
index 303ffa76ce26869a5faffc4fd75de3ebb231e9d7..df1a223dec76030b3d10b273dfc5605811cda538 100644
--- a/device/usb/usb_device_filter_unittest.cc
+++ b/device/usb/usb_device_filter_unittest.cc
@@ -20,15 +20,8 @@ using testing::Return;
class UsbFilterTest : public testing::Test {
public:
void SetUp() override {
- UsbInterfaceDescriptor interface;
- interface.interface_number = 1;
- interface.alternate_setting = 0;
- interface.interface_class = 0xFF;
- interface.interface_subclass = 0x42;
- interface.interface_protocol = 0x01;
-
- UsbConfigDescriptor config;
- config.interfaces.push_back(interface);
+ UsbConfigDescriptor config(1, false, false, 0);
+ config.interfaces.emplace_back(1, 0, 0xff, 0x42, 0x01);
android_phone_ = new MockUsbDevice(0x18d1, 0x4ee2, config);
}
« no previous file with comments | « device/usb/usb_device_android.cc ('k') | device/usb/usb_device_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698