Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: device/usb/usb_interface_android.cc

Issue 1468423003: Construct USB descriptors over explicit values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Android code. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_endpoint_android.cc ('k') | extensions/browser/api/usb/usb_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_interface_android.cc
diff --git a/device/usb/usb_interface_android.cc b/device/usb/usb_interface_android.cc
index 60403aed2da0ffbd94c153dbe6c94c6b435a30b5..fefe6713f9a40ab93fb35479b0dd9b99d6d34d25 100644
--- a/device/usb/usb_interface_android.cc
+++ b/device/usb/usb_interface_android.cc
@@ -23,17 +23,12 @@ UsbInterfaceDescriptor UsbInterfaceAndroid::Convert(
ScopedJavaLocalRef<jobject> wrapper =
Java_ChromeUsbInterface_create(env, usb_interface.obj());
- UsbInterfaceDescriptor interface;
- interface.interface_number =
- Java_ChromeUsbInterface_getInterfaceNumber(env, wrapper.obj());
- interface.alternate_setting =
- Java_ChromeUsbInterface_getAlternateSetting(env, wrapper.obj());
- interface.interface_class =
- Java_ChromeUsbInterface_getInterfaceClass(env, wrapper.obj());
- interface.interface_subclass =
- Java_ChromeUsbInterface_getInterfaceSubclass(env, wrapper.obj());
- interface.interface_protocol =
- Java_ChromeUsbInterface_getInterfaceProtocol(env, wrapper.obj());
+ UsbInterfaceDescriptor interface(
+ Java_ChromeUsbInterface_getInterfaceNumber(env, wrapper.obj()),
+ Java_ChromeUsbInterface_getAlternateSetting(env, wrapper.obj()),
+ Java_ChromeUsbInterface_getInterfaceClass(env, wrapper.obj()),
+ Java_ChromeUsbInterface_getInterfaceSubclass(env, wrapper.obj()),
+ Java_ChromeUsbInterface_getInterfaceProtocol(env, wrapper.obj()));
ScopedJavaLocalRef<jobjectArray> endpoints =
Java_ChromeUsbInterface_getEndpoints(env, wrapper.obj());
« no previous file with comments | « device/usb/usb_endpoint_android.cc ('k') | extensions/browser/api/usb/usb_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698