Make [TypeChecking=Interface] the default

Make [TypeChecking=Interface] the default

Add [LegacyInterfaceTypeChecking] as needed to ensure that there are no
changes to the generated code. It was added to the members wherever
possible, but in a few cases it was necessary to keep at the interface
level. In all but one of these are cases it is because the constructor
would otherwise change. The remaining case is FontFaceSet, where
setlike<FontFace> results in generated has(), add() and delete() methods
which would otherwise change.

90 instances of [LegacyInterfaceTypeChecking] were added, and 206
instances of [TypeChecking=Interface] were removed, in source/ and
modules/ combined.

In bindings/tests/, most tests that were previously for
[TypeChecking=Interface] were changed to instead test
[LegacyInterfaceTypeChecking], as that is now the special case.

BUG=462561
Committed: https://crrev.com/0443b48253b56ed9bbd6597cbbad8f568c053c38
Cr-Commit-Position: refs/heads/master@{#361599}

[philipj_slow, 2015-11-24 15:56:46]

Description was changed from

==========
Make [TypeChecking=Interface] the default

BUG=
==========

to

==========
Make [TypeChecking=Interface] the default

Add [LegacyInterfaceTypeChecking] as needed to ensure that there are no
changes to the generated code. It was added to the members wherever
possible, but in a few cases it was necessary to keep at the interface
level. In all but one of these are cases it is because the constructor
would otherwise change. The remaining case is FontFaceSet, where
setlike<FontFace> results in generated has(), add() and delete() methods
which would otherwise change.

90 instances of [LegacyInterfaceTypeChecking] were added, and 206
instances of [TypeChecking=Interface] were removed, in source/ and
modules/ combined.

BUG=462561
==========

[philipj_slow, 2015-11-24 15:58:52]

Description was changed from

==========
Make [TypeChecking=Interface] the default

Add [LegacyInterfaceTypeChecking] as needed to ensure that there are no
changes to the generated code. It was added to the members wherever
possible, but in a few cases it was necessary to keep at the interface
level. In all but one of these are cases it is because the constructor
would otherwise change. The remaining case is FontFaceSet, where
setlike<FontFace> results in generated has(), add() and delete() methods
which would otherwise change.

90 instances of [LegacyInterfaceTypeChecking] were added, and 206
instances of [TypeChecking=Interface] were removed, in source/ and
modules/ combined.

BUG=462561
==========

to

==========
Make [TypeChecking=Interface] the default

Add [LegacyInterfaceTypeChecking] as needed to ensure that there are no
changes to the generated code. It was added to the members wherever
possible, but in a few cases it was necessary to keep at the interface
level. In all but one of these are cases it is because the constructor
would otherwise change. The remaining case is FontFaceSet, where
setlike<FontFace> results in generated has(), add() and delete() methods
which would otherwise change.

90 instances of [LegacyInterfaceTypeChecking] were added, and 206
instances of [TypeChecking=Interface] were removed, in source/ and
modules/ combined.

In bindings/tests/, most tests that were previously for
[TypeChecking=Interface] were changed to instead test
[LegacyInterfaceTypeChecking], as that is now the special case.

BUG=462561
==========

[philipj_slow, 2015-11-24 15:59:11]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 16:01:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466563003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466563003/60001

[philipj_slow, 2015-11-24 16:06:29]

philipj@opera.com changed reviewers:
+ yukishiino@chromium.org

[philipj_slow, 2015-11-24 16:06:30]

yukishiino@, PTAL! For a change of this size I don't want to bother each
individual module owner, so if this looks good from a bindings perspective, I'll
ask another top-level owner to rubberstamp the rest, and then send a PSA to
blink-dev to explain why there is now [LegacyInterfaceTypeChecking] sprinkled
around the IDL files and how to go about removing them.

[commit-bot: I haz the power, 2015-11-24 17:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 17:46:23]

Dry run: This issue passed the CQ dry run.

[haraken, 2015-11-24 23:36:15]

LGTM on my side.

[Yuki, 2015-11-25 04:56:12]

Great work!  lgtm.

[philipj_slow, 2015-11-25 06:55:52]

philipj@opera.com changed reviewers:
+ jochen@chromium.org

[philipj_slow, 2015-11-25 06:55:53]

Jochen, can you please rubberstamp this? After landing, I will send a PSA to
blink-dev to explain the change.

[philipj_slow, 2015-11-25 06:57:46]

On 2015/11/25 06:55:53, philipj wrote:
> Jochen, can you please rubberstamp this? After landing, I will send a PSA to
> blink-dev to explain the change.

Sorry, never mind, haraken is core/ and modules/ owner, so I'll go ahead and
land before this conflicts.

[philipj_slow, 2015-11-25 06:57:55]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-11-25 06:59:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466563003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466563003/60001

[commit-bot: I haz the power, 2015-11-25 07:08:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-25 07:09:38]

Patchset 4 (id:??) landed as
https://crrev.com/0443b48253b56ed9bbd6597cbbad8f568c053c38
Cr-Commit-Position: refs/heads/master@{#361599}