Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1466563003: Make [TypeChecking=Interface] the default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # coding=utf-8 2 # coding=utf-8
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 1337 matching lines...) Expand 10 before | Expand all | Expand 10 after
1348 def property_setter(setter, interface): 1348 def property_setter(setter, interface):
1349 if not setter: 1349 if not setter:
1350 return None 1350 return None
1351 1351
1352 extended_attributes = setter.extended_attributes 1352 extended_attributes = setter.extended_attributes
1353 idl_type = setter.arguments[1].idl_type 1353 idl_type = setter.arguments[1].idl_type
1354 idl_type.add_includes_for_type(extended_attributes) 1354 idl_type.add_includes_for_type(extended_attributes)
1355 is_call_with_script_state = v8_utilities.has_extended_attribute_value(setter , 'CallWith', 'ScriptState') 1355 is_call_with_script_state = v8_utilities.has_extended_attribute_value(setter , 'CallWith', 'ScriptState')
1356 is_raises_exception = 'RaisesException' in extended_attributes 1356 is_raises_exception = 'RaisesException' in extended_attributes
1357 1357
1358 # [TypeChecking=Interface] / [LegacyInterfaceTypeChecking] 1358 # [LegacyInterfaceTypeChecking]
1359 has_type_checking_interface = ( 1359 has_type_checking_interface = (
1360 not is_legacy_interface_type_checking(interface, setter) and 1360 not is_legacy_interface_type_checking(interface, setter) and
1361 idl_type.is_wrapper_type) 1361 idl_type.is_wrapper_type)
1362 1362
1363 return { 1363 return {
1364 'has_exception_state': (is_raises_exception or 1364 'has_exception_state': (is_raises_exception or
1365 idl_type.v8_conversion_needs_exception_state), 1365 idl_type.v8_conversion_needs_exception_state),
1366 'has_type_checking_interface': has_type_checking_interface, 1366 'has_type_checking_interface': has_type_checking_interface,
1367 'idl_type': idl_type.base_type, 1367 'idl_type': idl_type.base_type,
1368 'is_call_with_script_state': is_call_with_script_state, 1368 'is_call_with_script_state': is_call_with_script_state,
(...skipping 12 matching lines...) Expand all
1381 1381
1382 extended_attributes = deleter.extended_attributes 1382 extended_attributes = deleter.extended_attributes
1383 idl_type = deleter.idl_type 1383 idl_type = deleter.idl_type
1384 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState') 1384 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState')
1385 return { 1385 return {
1386 'is_call_with_script_state': is_call_with_script_state, 1386 'is_call_with_script_state': is_call_with_script_state,
1387 'is_custom': 'Custom' in extended_attributes, 1387 'is_custom': 'Custom' in extended_attributes,
1388 'is_raises_exception': 'RaisesException' in extended_attributes, 1388 'is_raises_exception': 'RaisesException' in extended_attributes,
1389 'name': cpp_name(deleter), 1389 'name': cpp_name(deleter),
1390 } 1390 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_attributes.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698